From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJlfy-00038n-MI for linux-mtd@lists.infradead.org; Fri, 18 May 2018 20:08:32 +0000 Date: Fri, 18 May 2018 22:08:09 +0200 From: Boris Brezillon To: YuheiOKAWA Cc: linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: spi-nor: Add support for EN25QH32 Message-ID: <20180518220809.14071539@bbrezillon> In-Reply-To: <1526524827-30380-1-git-send-email-tochiro.srchack@gmail.com> References: <1526524384-30303-1-git-send-email-tochiro.srchack@gmail.com> <1526524827-30380-1-git-send-email-tochiro.srchack@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 17 May 2018 11:40:27 +0900 YuheiOKAWA wrote: > Add support for Eon en25qh32 spi nor flash. > > Sorry, very sorry. > I had misspelled it. chip name is en25qh32, non en25ph32. Queued to spi-nor/next after removing this sentence :-). Next time you want to add extra information that you don't want to appear in the commit, just put it after the "---" separator ;-). Also, you should prefix your patch with "[PATCH v2]" and add a changelog after the "---". Something like: " --- Changes in v2: - blablabla " Thanks, Boris > > Signed-off-by: YuheiOKAWA > --- > drivers/mtd/spi-nor/spi-nor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 5bfa36e..7bc556c 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -980,6 +980,7 @@ static const struct flash_info spi_nor_ids[] = { > { "en25q32b", INFO(0x1c3016, 0, 64 * 1024, 64, 0) }, > { "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) }, > { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) }, > + { "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) }, > { "en25qh128", INFO(0x1c7018, 0, 64 * 1024, 256, 0) }, > { "en25qh256", INFO(0x1c7019, 0, 64 * 1024, 512, 0) }, > { "en25s64", INFO(0x1c3817, 0, 64 * 1024, 128, SECT_4K) },