[PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

The changes are to make sure to check the operation status.
Actually the flash write and erase error behavior is caused on our products.
The flash is Macronix flash device MX29GL512FHT2I-11G used by our products.
The patch series was separated for changes of flash write and erase.
Since those were not depended each other at the time.
But by additional changes the changes are related more as same way currently.
So combine patch series for the flash write and erase changes as v6.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org

Tokunori Ikegami (5):
  mtd: cfi_cmdset_0002: Change write buffer to check correct value
  mtd: cfi_cmdset_0002: Change definition naming to retry write
    operation
  mtd: cfi_cmdset_0002: Change erase functions to retry for error
  mtd: cfi_cmdset_0002: Change erase functions to check chip good only
  mtd: cfi_cmdset_0002: Change erase one block to enable XIP once

 drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++-------------
 1 file changed, 23 insertions(+), 13 deletions(-)

-- 
2.16.1

[PATCH v6 1/5] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

For the word write it is checked if the chip has the correct value.
But it is not checked for the write buffer as only checked if ready.
To make sure for the write buffer change to check the value.

It is enough as this patch is only checking the last written word.
Since it is described by data sheets to check the operation status.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
Changes since v5:
- None since the v4 change is just combined as same series by v6.

Changes since v3:
- Removed to check if chip ready.

Changes since v2:
- Just updated the patch to add v3 version into subject and desribe a changelog.

Changes since v1:
- Just changed to add Brian as Cc and the patch is sent to Boris-san as To

Changes since v0:
- Changed Split the part to change write buffer from the v1 patch

 drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index e397b80e40cc..1d6be8c63d39 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
 		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
 			break;
 
-		if (chip_ready(map, adr)) {
+		if (chip_good(map, adr, datum)) {
 			xip_enable(map, chip, adr);
 			goto op_done;
 		}
-- 
2.16.1

[PATCH v6 2/5] mtd: cfi_cmdset_0002: Change definition naming to retry write operation

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

The definition can be used for other program and erase operations also.
So change the naming to MAX_RETRIES from MAX_WORD_RETRIES.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
Changes since v5:
- No change for this patch.

Changes since v4:
- No change for this patch.

Changes since v3:
- The patch series are just rebased since the coding style fix has been applied.

Changes since v2:
- Change the definition naming to MAX_RETRIES from MAX_WRITE_RETRIES.

Changes since v1:
- Just split the change from the v1 patch.

 drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 1d6be8c63d39..0b67f90415fd 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -42,7 +42,7 @@
 #define AMD_BOOTLOC_BUG
 #define FORCE_WORD_WRITE 0
 
-#define MAX_WORD_RETRIES 3
+#define MAX_RETRIES 3
 
 #define SST49LF004B		0x0060
 #define SST49LF040B		0x0050
@@ -1646,7 +1646,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
 		map_write(map, CMD(0xF0), chip->start);
 		/* FIXME - should have reset delay before continuing */
 
-		if (++retry_cnt <= MAX_WORD_RETRIES)
+		if (++retry_cnt <= MAX_RETRIES)
 			goto retry;
 
 		ret = -EIO;
@@ -2105,7 +2105,7 @@ static int do_panic_write_oneword(struct map_info *map, struct flchip *chip,
 		map_write(map, CMD(0xF0), chip->start);
 		/* FIXME - should have reset delay before continuing */
 
-		if (++retry_cnt <= MAX_WORD_RETRIES)
+		if (++retry_cnt <= MAX_RETRIES)
 			goto retry;
 
 		ret = -EIO;
-- 
2.16.1

[PATCH v6 3/5] mtd: cfi_cmdset_0002: Change erase functions to retry for error

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

For the word write functions it is retried for error.
But it is not implemented to retry for the erase functions.
To make sure for the erase functions change to retry as same.

This is needed to prevent the flash erase error caused only once.
It was caused by the error case of chip_good() in the do_erase_oneblock().
Also it was confirmed on the MACRONIX flash device MX29GL512FHT2I-11G.
But the error issue behavior is not able to reproduce at this moment.
The flash controller is parallel Flash interface integrated on BCM53003.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
Changes since v5:
- No change for this patch.

Changes since v4:
- Just fixed the commit message.

Changes since v3:
- The patch series are just rebased since the coding style fix has been applied.

Changes since v2:
- Just fix the commit message of patch to retry the chip erase error.

Changes since v1:
- Just split the change from the v1 patch.

 drivers/mtd/chips/cfi_cmdset_0002.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 0b67f90415fd..e703900975d4 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -2240,6 +2240,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
 	unsigned long int adr;
 	DECLARE_WAITQUEUE(wait, current);
 	int ret = 0;
+	int retry_cnt = 0;
 
 	adr = cfi->addr_unlock1;
 
@@ -2257,6 +2258,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
 	ENABLE_VPP(map);
 	xip_disable(map, chip, adr);
 
+ retry:
 	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
@@ -2310,6 +2312,9 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
 		map_write(map, CMD(0xF0), chip->start);
 		/* FIXME - should have reset delay before continuing */
 
+		if (++retry_cnt <= MAX_RETRIES)
+			goto retry;
+
 		ret = -EIO;
 	}
 
@@ -2329,6 +2334,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 	unsigned long timeo = jiffies + HZ;
 	DECLARE_WAITQUEUE(wait, current);
 	int ret = 0;
+	int retry_cnt = 0;
 
 	adr += chip->start;
 
@@ -2346,6 +2352,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 	ENABLE_VPP(map);
 	xip_disable(map, chip, adr);
 
+ retry:
 	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
@@ -2402,6 +2409,9 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 		map_write(map, CMD(0xF0), chip->start);
 		/* FIXME - should have reset delay before continuing */
 
+		if (++retry_cnt <= MAX_RETRIES)
+			goto retry;
+
 		ret = -EIO;
 	}
 
-- 
2.16.1

[PATCH v6 4/5] mtd: cfi_cmdset_0002: Change erase functions to check chip good only

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

Currently the functions use to check both chip ready and good.
But the chip ready is not enough to check the operation status.
So change this to check the chip good instead of this.
About the retry functions to make sure the error handling remain it.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
Changes since v5:
- None since this change is implemented by v6 patch series.

 drivers/mtd/chips/cfi_cmdset_0002.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index e703900975d4..6adda4dc2007 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -2294,12 +2294,13 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
 			chip->erase_suspended = 0;
 		}
 
-		if (chip_ready(map, adr))
+		if (chip_good(map, adr, map_word_ff(map)))
 			break;
 
 		if (time_after(jiffies, timeo)) {
 			printk(KERN_WARNING "MTD %s(): software timeout\n",
 			       __func__);
+			ret = -EIO;
 			break;
 		}
 
@@ -2307,15 +2308,15 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
 		UDELAY(map, chip, adr, 1000000/HZ);
 	}
 	/* Did we succeed? */
-	if (!chip_good(map, adr, map_word_ff(map))) {
+	if (ret) {
 		/* reset on all failures. */
 		map_write(map, CMD(0xF0), chip->start);
 		/* FIXME - should have reset delay before continuing */
 
-		if (++retry_cnt <= MAX_RETRIES)
+		if (++retry_cnt <= MAX_RETRIES) {
+			ret = 0;
 			goto retry;
-
-		ret = -EIO;
+		}
 	}
 
 	chip->state = FL_READY;
@@ -2388,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 			chip->erase_suspended = 0;
 		}
 
-		if (chip_ready(map, adr)) {
+		if (chip_good(map, adr, map_word_ff(map))) {
 			xip_enable(map, chip, adr);
 			break;
 		}
@@ -2397,6 +2398,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 			xip_enable(map, chip, adr);
 			printk(KERN_WARNING "MTD %s(): software timeout\n",
 			       __func__);
+			ret = -EIO;
 			break;
 		}
 
@@ -2404,15 +2406,15 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 		UDELAY(map, chip, adr, 1000000/HZ);
 	}
 	/* Did we succeed? */
-	if (!chip_good(map, adr, map_word_ff(map))) {
+	if (ret) {
 		/* reset on all failures. */
 		map_write(map, CMD(0xF0), chip->start);
 		/* FIXME - should have reset delay before continuing */
 
-		if (++retry_cnt <= MAX_RETRIES)
+		if (++retry_cnt <= MAX_RETRIES) {
+			ret = 0;
 			goto retry;
-
-		ret = -EIO;
+		}
 	}
 
 	chip->state = FL_READY;
-- 
2.16.1

[PATCH v6 5/5] mtd: cfi_cmdset_0002: Change erase one block to enable XIP once

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

To enable XIP it is executed both normal and error cases.
This call can be moved after the for loop as same with erase chip.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
Changes since v5:
- None since this change is implemented by v6 patch series.

 drivers/mtd/chips/cfi_cmdset_0002.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 6adda4dc2007..6c681cbf2d37 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -2389,13 +2389,10 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 			chip->erase_suspended = 0;
 		}
 
-		if (chip_good(map, adr, map_word_ff(map))) {
-			xip_enable(map, chip, adr);
+		if (chip_good(map, adr, map_word_ff(map)))
 			break;
-		}
 
 		if (time_after(jiffies, timeo)) {
-			xip_enable(map, chip, adr);
 			printk(KERN_WARNING "MTD %s(): software timeout\n",
 			       __func__);
 			ret = -EIO;
@@ -2418,6 +2415,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
 	}
 
 	chip->state = FL_READY;
+	xip_enable(map, chip, adr);
 	DISABLE_VPP(map);
 	put_chip(map, chip, adr);
 	mutex_unlock(&chip->mutex);
-- 
2.16.1

Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[Joakim Tjernlund]

I think the patches look good but I think they should go
to stable as well.

 Jocke

On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote:
> 
> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> 
> The changes are to make sure to check the operation status.
> Actually the flash write and erase error behavior is caused on our products.
> The flash is Macronix flash device MX29GL512FHT2I-11G used by our products.
> The patch series was separated for changes of flash write and erase.
> Since those were not depended each other at the time.
> But by additional changes the changes are related more as same way currently.
> So combine patch series for the flash write and erase changes as v6.
> 
> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: linux-mtd@lists.infradead.org
> 
> Tokunori Ikegami (5):
>   mtd: cfi_cmdset_0002: Change write buffer to check correct value
>   mtd: cfi_cmdset_0002: Change definition naming to retry write
>     operation
>   mtd: cfi_cmdset_0002: Change erase functions to retry for error
>   mtd: cfi_cmdset_0002: Change erase functions to check chip good only
>   mtd: cfi_cmdset_0002: Change erase one block to enable XIP once
> 
>  drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++-------------
>  1 file changed, 23 insertions(+), 13 deletions(-)
> 
> --
> 2.16.1
> 

RE: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[IKEGAMI Tokunori]

Hi Boris-san,

Could you please apply the patches if no problem?
Or still should we wait if any other comment?
Let me confirm these things since we are waiting to apply them for our product problem as resolution.

By the way I think that the commit message of patches can be changed to Jocke-san as "Reviewed-by" from "Cc" as below.
  - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
  + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>

Since actually the changes have been reviewed by him as the mail below.
Also our company mail system has been changed so now I can send the patches with my email address as sender instead of the smtpuser address.
If needed I will resend patches or send them as new version patches again to change the commit message and send address.

Regards,
Ikegami

> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]
> Sent: Thursday, May 17, 2018 10:12 PM
> To: boris.brezillon@bootlin.com
> Cc: IKEGAMI Tokunori; PACKHAM Chris; linux-mtd@lists.infradead.org;
> cyrille.pitchen@wedev4u.fr; dwmw2@infradead.org;
> computersforpeace@gmail.com; boris.brezillon@free-electrons.com;
> richard@nod.at; marek.vasut@gmail.com
> Subject: Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase
> functions
> 
> I think the patches look good but I think they should go
> to stable as well.
> 
>  Jocke
> 
> On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote:
> >
> > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> >
> > The changes are to make sure to check the operation status.
> > Actually the flash write and erase error behavior is caused on our
> products.
> > The flash is Macronix flash device MX29GL512FHT2I-11G used by our
> products.
> > The patch series was separated for changes of flash write and erase.
> > Since those were not depended each other at the time.
> > But by additional changes the changes are related more as same way
> currently.
> > So combine patch series for the flash write and erase changes as v6.
> >
> > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> > Cc: linux-mtd@lists.infradead.org
> >
> > Tokunori Ikegami (5):
> >   mtd: cfi_cmdset_0002: Change write buffer to check correct value
> >   mtd: cfi_cmdset_0002: Change definition naming to retry write
> >     operation
> >   mtd: cfi_cmdset_0002: Change erase functions to retry for error
> >   mtd: cfi_cmdset_0002: Change erase functions to check chip good only
> >   mtd: cfi_cmdset_0002: Change erase one block to enable XIP once
> >
> >  drivers/mtd/chips/cfi_cmdset_0002.c | 36
> +++++++++++++++++++++++-------------
> >  1 file changed, 23 insertions(+), 13 deletions(-)
> >
> > --
> > 2.16.1
> >

Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[Chris Packham]

Hi Ikgegami-san,

On 25/05/18 15:03, IKEGAMI Tokunori wrote:
> Hi Boris-san,
> 
> Could you please apply the patches if no problem?
> Or still should we wait if any other comment?

Probably best to let the world turn for a bit longer. I imagine most of 
the Linux subsystem maintainers are busy with the last stage of the 
merge window for 4.17.

> Let me confirm these things since we are waiting to apply them for
> our product problem as resolution.

I think things are far enough along now that we can apply these to our 
kernel fork. If there are any new changes we can always revert and apply 
updated versions.

> By the way I think that the commit message of patches can be changed
> to Jocke-san as "Reviewed-by" from "Cc" as below.
>    - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
>    + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> 
> Since actually the changes have been reviewed by him as the mail
> below.
> Also our company mail system has been changed so now I can send the
> patches with my email address as sender instead of the smtpuser address.
> If needed I will resend patches or send them as new version patches
> again to change the commit message and send address.
> 
> Regards,
> Ikegami
> 
>> -----Original Message-----
>> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]
>> Sent: Thursday, May 17, 2018 10:12 PM
>> To: boris.brezillon@bootlin.com
>> Cc: IKEGAMI Tokunori; PACKHAM Chris; linux-mtd@lists.infradead.org;
>> cyrille.pitchen@wedev4u.fr; dwmw2@infradead.org;
>> computersforpeace@gmail.com; boris.brezillon@free-electrons.com;
>> richard@nod.at; marek.vasut@gmail.com
>> Subject: Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase
>> functions
>>
>> I think the patches look good but I think they should go
>> to stable as well.
>>
>>   Jocke
>>
>> On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote:
>>>
>>> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
>>>
>>> The changes are to make sure to check the operation status.
>>> Actually the flash write and erase error behavior is caused on our
>> products.
>>> The flash is Macronix flash device MX29GL512FHT2I-11G used by our
>> products.
>>> The patch series was separated for changes of flash write and erase.
>>> Since those were not depended each other at the time.
>>> But by additional changes the changes are related more as same way
>> currently.
>>> So combine patch series for the flash write and erase changes as v6.
>>>
>>> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
>>> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
>>> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
>>> Cc: Marek Vasut <marek.vasut@gmail.com>
>>> Cc: Richard Weinberger <richard@nod.at>
>>> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
>>> Cc: linux-mtd@lists.infradead.org
>>>
>>> Tokunori Ikegami (5):
>>>    mtd: cfi_cmdset_0002: Change write buffer to check correct value
>>>    mtd: cfi_cmdset_0002: Change definition naming to retry write
>>>      operation
>>>    mtd: cfi_cmdset_0002: Change erase functions to retry for error
>>>    mtd: cfi_cmdset_0002: Change erase functions to check chip good only
>>>    mtd: cfi_cmdset_0002: Change erase one block to enable XIP once
>>>
>>>   drivers/mtd/chips/cfi_cmdset_0002.c | 36
>> +++++++++++++++++++++++-------------
>>>   1 file changed, 23 insertions(+), 13 deletions(-)
>>>
>>> --
>>> 2.16.1
>>>
> 

RE: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[IKEGAMI Tokunori]

Hi Chris-san,

Thank you so much for your advice.

> Probably best to let the world turn for a bit longer. I imagine most of
> the Linux subsystem maintainers are busy with the last stage of the
> merge window for 4.17.

  I see so I will wait more.

> I think things are far enough along now that we can apply these to our
> kernel fork. If there are any new changes we can always revert and apply
> updated versions.

  Okay I will send the patches to you separately to apply to our kernel fork.

Regards,
Ikegami

Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[Boris Brezillon]

On Fri, 25 May 2018 03:03:28 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:

> Hi Boris-san,
> 
> Could you please apply the patches if no problem?

Actually I never received your v6, and I can't find it in linux-mtd
either. Interestingly, it's in patchwork, so maybe a problem on my side.

> Or still should we wait if any other comment?

Not really, maybe add the Cc:stable tag if you think this is needed.

> Let me confirm these things since we are waiting to apply them for our product problem as resolution.
> 
> By the way I think that the commit message of patches can be changed to Jocke-san as "Reviewed-by" from "Cc" as below.
>   - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
>   + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> 
> Since actually the changes have been reviewed by him as the mail below.

Normally you should wait for an official "Reviewed-by" tag. I just
asked Joakim.

> Also our company mail system has been changed so now I can send the patches with my email address as sender instead of the smtpuser address.

That's appreciated.

> If needed I will resend patches or send them as new version patches again to change the commit message and send address.

Yes please, send a new version.

Thanks,

Boris

RE: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[IKEGAMI Tokunori]

Hi Boris-san,

Yes I have just sent v7 version patches so please review them.

Regards,
Ikegami

> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> Sent: Monday, May 28, 2018 12:39 AM
> To: IKEGAMI Tokunori
> Cc: Joakim Tjernlund; PACKHAM Chris; linux-mtd@lists.infradead.org;
> cyrille.pitchen@wedev4u.fr; dwmw2@infradead.org;
> computersforpeace@gmail.com; boris.brezillon@free-electrons.com;
> richard@nod.at; marek.vasut@gmail.com
> Subject: Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase
> functions
> 
> On Fri, 25 May 2018 03:03:28 +0000
> IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:
> 
> > Hi Boris-san,
> >
> > Could you please apply the patches if no problem?
> 
> Actually I never received your v6, and I can't find it in linux-mtd
> either. Interestingly, it's in patchwork, so maybe a problem on my side.
> 
> > Or still should we wait if any other comment?
> 
> Not really, maybe add the Cc:stable tag if you think this is needed.
> 
> > Let me confirm these things since we are waiting to apply them for our
> product problem as resolution.
> >
> > By the way I think that the commit message of patches can be changed to
> Jocke-san as "Reviewed-by" from "Cc" as below.
> >   - Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> >   + Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> >
> > Since actually the changes have been reviewed by him as the mail below.
> 
> Normally you should wait for an official "Reviewed-by" tag. I just
> asked Joakim.
> 
> > Also our company mail system has been changed so now I can send the patches
> with my email address as sender instead of the smtpuser address.
> 
> That's appreciated.
> 
> > If needed I will resend patches or send them as new version patches again
> to change the commit message and send address.
> 
> Yes please, send a new version.
> 
> Thanks,
> 
> Boris

Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[Boris Brezillon]

Hi Joakim,

On Thu, 17 May 2018 13:12:26 +0000
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote:

> I think the patches look good

Should I add your Reviewed-by tag (maybe Tested-by as well)?

> but I think they should go to stable as well.

Then I'll need a v7 with the "Cc: stable@vger.kernel.org" tag. Also,
some patches are clearly not fixes (patch 2 and 5 at least).

Regards,

Boris

> 
>  Jocke
> 
> On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote:
> > 
> > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> > 
> > The changes are to make sure to check the operation status.
> > Actually the flash write and erase error behavior is caused on our products.
> > The flash is Macronix flash device MX29GL512FHT2I-11G used by our products.
> > The patch series was separated for changes of flash write and erase.
> > Since those were not depended each other at the time.
> > But by additional changes the changes are related more as same way currently.
> > So combine patch series for the flash write and erase changes as v6.
> > 
> > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> > Cc: linux-mtd@lists.infradead.org
> > 
> > Tokunori Ikegami (5):
> >   mtd: cfi_cmdset_0002: Change write buffer to check correct value
> >   mtd: cfi_cmdset_0002: Change definition naming to retry write
> >     operation
> >   mtd: cfi_cmdset_0002: Change erase functions to retry for error
> >   mtd: cfi_cmdset_0002: Change erase functions to check chip good only
> >   mtd: cfi_cmdset_0002: Change erase one block to enable XIP once
> > 
> >  drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++-------------
> >  1 file changed, 23 insertions(+), 13 deletions(-)
> > 
> > --
> > 2.16.1
> >   
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v6 0/5] mtd: cfi_cmdset_0002: Change write and erase functions

[Joakim Tjernlund]

On Sun, 2018-05-27 at 17:33 +0200, Boris Brezillon wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> Hi Joakim,
> 
> On Thu, 17 May 2018 13:12:26 +0000
> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote:
> 
> > I think the patches look good
> 
> Should I add your Reviewed-by tag (maybe Tested-by as well)?

I have only reviewed them so add a:
  Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>

> 
> > but I think they should go to stable as well.
> 
> Then I'll need a v7 with the "Cc: stable@vger.kernel.org" tag. Also,
> some patches are clearly not fixes (patch 2 and 5 at least).

But they are all needed as the fixes builds upon them? So all go to stable I think.

> 
> Regards,
> 
> Boris
> 
> > 
> >  Jocke
> > 
> > On Wed, 2018-05-16 at 02:11 +0900, smtpuser wrote:
> > > 
> > > From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> > > 
> > > The changes are to make sure to check the operation status.
> > > Actually the flash write and erase error behavior is caused on our products.
> > > The flash is Macronix flash device MX29GL512FHT2I-11G used by our products.
> > > The patch series was separated for changes of flash write and erase.
> > > Since those were not depended each other at the time.
> > > But by additional changes the changes are related more as same way currently.
> > > So combine patch series for the flash write and erase changes as v6.
> > > 
> > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> > > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > > Cc: Brian Norris <computersforpeace@gmail.com>
> > > Cc: David Woodhouse <dwmw2@infradead.org>
> > > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> > > Cc: Marek Vasut <marek.vasut@gmail.com>
> > > Cc: Richard Weinberger <richard@nod.at>
> > > Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> > > Cc: linux-mtd@lists.infradead.org
> > > 
> > > Tokunori Ikegami (5):
> > >   mtd: cfi_cmdset_0002: Change write buffer to check correct value
> > >   mtd: cfi_cmdset_0002: Change definition naming to retry write
> > >     operation
> > >   mtd: cfi_cmdset_0002: Change erase functions to retry for error
> > >   mtd: cfi_cmdset_0002: Change erase functions to check chip good only
> > >   mtd: cfi_cmdset_0002: Change erase one block to enable XIP once
> > > 
> > >  drivers/mtd/chips/cfi_cmdset_0002.c | 36 +++++++++++++++++++++++-------------
> > >  1 file changed, 23 insertions(+), 13 deletions(-)
> > > 
> > > --
> > > 2.16.1
> > > 
> > 
> > ______________________________________________________
> > Linux MTD discussion mailing list
> > http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 
>