From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Stefan Agner <stefan@agner.ch>,
boris.brezillon@bootlin.com, dwmw2@infradead.org,
computersforpeace@gmail.com, marek.vasut@gmail.com,
mark.rutland@arm.com, thierry.reding@gmail.com,
mturquette@baylibre.com, sboyd@kernel.org, dev@lynxeye.de,
richard@nod.at, marcel@ziswiler.com, krzk@kernel.org,
digetx@gmail.com, benjamin.lindqvist@endian.se,
jonathanh@nvidia.com, pdeschrijver@nvidia.com,
pgaikwad@nvidia.com, mirza.krak@gmail.com,
linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mtd: rawnand: tegra: add devicetree binding
Date: Thu, 31 May 2018 08:42:05 +0200 [thread overview]
Message-ID: <20180531084205.38bfe90f@xps13> (raw)
In-Reply-To: <20180531034523.GA5417@rob-hp-laptop>
Hi Rob,
On Wed, 30 May 2018 22:45:23 -0500, Rob Herring <robh@kernel.org> wrote:
> On Mon, May 28, 2018 at 12:23:54AM +0200, Miquel Raynal wrote:
> > Hi Stefan,
> >
> > On Sun, 27 May 2018 23:54:38 +0200, Stefan Agner <stefan@agner.ch>
> > wrote:
> >
> > > From: Lucas Stach <dev@lynxeye.de>
> > >
> > > This adds the devicetree binding for the Tegra 2 NAND flash
> > > controller.
> > >
> > > Signed-off-by: Lucas Stach <dev@lynxeye.de>
> > > Signed-off-by: Stefan Agner <stefan@agner.ch>
> > > ---
> > > .../bindings/mtd/nvidia,tegra20-nand.txt | 62 +++++++++++++++++++
> > > 1 file changed, 62 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt b/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt
> > > new file mode 100644
> > > index 000000000000..49e472af1b39
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt
> > > @@ -0,0 +1,62 @@
> > > +NVIDIA Tegra NAND Flash controller
> > > +
> > > +Required properties:
> > > +- compatible: Must be one of:
> >
> > Nitpick: just put the compatible here as there is only one?
>
> No, this is how I ask people to format it.
Oh, ok, I'll remember it for my own DT patches then :)
Thanks,
Miquèl
prev parent reply other threads:[~2018-05-31 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-27 21:54 [PATCH v2 2/6] mtd: rawnand: tegra: add devicetree binding Stefan Agner
2018-05-27 22:23 ` Miquel Raynal
2018-05-31 3:45 ` Rob Herring
2018-05-31 6:42 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531084205.38bfe90f@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=benjamin.lindqvist@endian.se \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mirza.krak@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).