From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: miquel.raynal@bootlin.com, dwmw2@infradead.org,
computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH v3 1/4] mtd: rawnand: marvell: Handle on-die ECC
Date: Wed, 20 Jun 2018 09:46:54 +0200 [thread overview]
Message-ID: <20180620094654.4280caeb@bbrezillon> (raw)
In-Reply-To: <20180620050544.31549-2-chris.packham@alliedtelesis.co.nz>
Hi Chris,
On Wed, 20 Jun 2018 17:05:41 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> From the controllers point of view this is the same as no or
> software only ECC.
>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
I'm nitpicking, but we usually put the R-b/A-b tags after the author
SoB.
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Changes in v2:
> - New
> Changes in v3:
> - Add review from Boris
>
> drivers/mtd/nand/raw/marvell_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index ebb1d141b900..ba6889bbe802 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -2157,6 +2157,7 @@ static int marvell_nand_ecc_init(struct mtd_info *mtd,
> break;
> case NAND_ECC_NONE:
> case NAND_ECC_SOFT:
> + case NAND_ECC_ON_DIE:
> if (!nfc->caps->is_nfcv2 && mtd->writesize != SZ_512 &&
> mtd->writesize != SZ_2K) {
> dev_err(nfc->dev, "NFCv1 cannot write %d bytes pages\n",
next prev parent reply other threads:[~2018-06-20 7:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 5:05 [PATCH v3 0/4] mtd: rawnand: support MT29F1G08ABAFAWP-ITE:F Chris Packham
2018-06-20 5:05 ` [PATCH v3 1/4] mtd: rawnand: marvell: Handle on-die ECC Chris Packham
2018-06-20 7:46 ` Boris Brezillon [this message]
2018-06-20 21:10 ` Chris Packham
2018-06-20 5:05 ` [PATCH v3 2/4] mtd: rawnand: add manufacturer fixup for ONFI parameter page Chris Packham
2018-06-20 7:49 ` Boris Brezillon
2018-06-20 5:05 ` [PATCH v3 3/4] mtd: rawnand: micron: add fixup for ONFI revision Chris Packham
2018-06-20 7:54 ` Boris Brezillon
2018-06-20 21:12 ` Chris Packham
2018-06-21 7:14 ` Boris Brezillon
2018-06-20 5:05 ` [PATCH v3 4/4] mtd: rawnand: micron: support 8/512 on-die ECC Chris Packham
2018-06-20 8:02 ` Boris Brezillon
2018-06-20 22:22 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620094654.4280caeb@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).