From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw0-f194.google.com ([209.85.161.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fXTuW-0005vT-VV for linux-mtd@lists.infradead.org; Mon, 25 Jun 2018 16:00:55 +0000 Received: by mail-yw0-f194.google.com with SMTP id r19-v6so4930492ywc.10 for ; Mon, 25 Jun 2018 09:00:02 -0700 (PDT) Date: Mon, 25 Jun 2018 09:59:59 -0600 From: Rob Herring To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, Boris Brezillon , Miquel Raynal , Richard Weinberger , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse , Mark Rutland Subject: Re: [PATCH v4 3/5] dt-binding: mtd: denali_dt: document clock property Message-ID: <20180625155959.GA2820@rob-hp-laptop> References: <1529683598-25783-1-git-send-email-yamada.masahiro@socionext.com> <1529683598-25783-4-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529683598-25783-4-git-send-email-yamada.masahiro@socionext.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Jun 23, 2018 at 01:06:36AM +0900, Masahiro Yamada wrote: > Commit 30f9f2fb7ba0 ("mtd: denali: add a DT driver") supported the > clock enablement, but did not document it in the DT binding. > > In addition to the existing clock, this commit adds more clocks based > on the IP specification. > > According to the Denali User's Guide, this IP needs three clocks: > > - clk: controller core clock > > - clk_x: bus interface clock > > - ecc_clk: clock at which ECC circuitry is run > > The driver should accept the current single clock for the backward > compatibility, but the DT binding should represent the real hardware, > and future platforms must follow this. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v4: > - split into a separate patch > > > Documentation/devicetree/bindings/mtd/denali-nand.txt | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Rob Herring