From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: replace VMLINUX_SYMBOL_STR() with string literal
Date: Thu, 28 Jun 2018 09:29:36 +0200 [thread overview]
Message-ID: <20180628092936.6c4a097c@bbrezillon> (raw)
In-Reply-To: <1529768142-9989-1-git-send-email-yamada.masahiro@socionext.com>
On Sun, 24 Jun 2018 00:35:42 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> With the special case handling for Blackfin and Metag was removed by
> commit 94e58e0ac312 ("export.h: remove code for prefixing symbols with
> underscore"), VMLINUX_SYMBOL_STR() can be replaced with string literal.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied.
Thanks,
Boris
> ---
>
> drivers/mtd/chips/gen_probe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/chips/gen_probe.c b/drivers/mtd/chips/gen_probe.c
> index b57ceea..879bebf 100644
> --- a/drivers/mtd/chips/gen_probe.c
> +++ b/drivers/mtd/chips/gen_probe.c
> @@ -202,10 +202,10 @@ static inline struct mtd_info *cfi_cmdset_unknown(struct map_info *map,
> struct cfi_private *cfi = map->fldrv_priv;
> __u16 type = primary?cfi->cfiq->P_ID:cfi->cfiq->A_ID;
> #ifdef CONFIG_MODULES
> - char probename[sizeof(VMLINUX_SYMBOL_STR(cfi_cmdset_%4.4X))];
> + char probename[sizeof("cfi_cmdset_%4.4X")];
> cfi_cmdset_fn_t *probe_function;
>
> - sprintf(probename, VMLINUX_SYMBOL_STR(cfi_cmdset_%4.4X), type);
> + sprintf(probename, "cfi_cmdset_%4.4X", type);
>
> probe_function = __symbol_get(probename);
> if (!probe_function) {
prev parent reply other threads:[~2018-06-28 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 15:35 [PATCH] mtd: replace VMLINUX_SYMBOL_STR() with string literal Masahiro Yamada
2018-06-28 7:29 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628092936.6c4a097c@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox