From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
David Woodhouse <dwmw2@infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe_dt
Date: Sun, 1 Jul 2018 20:12:50 +0200 [thread overview]
Message-ID: <20180701201250.5f93b70e@xps13> (raw)
In-Reply-To: <1530132464-8210-1-git-send-email-martin@kaiser.cx>
Hi Martin,
Martin Kaiser <martin@kaiser.cx> wrote on Wed, 27 Jun 2018 22:47:44
+0200:
> Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can
> potentially be called at any time. After the __init functions are cleaned,
> mxcnd_probe_dt is no longer available. Calling it anyway causes a crash.
>
> mxcnd_probe used to be marked as __init, this was removed years ago.
> Remove the __init qualifier from from mxcnd_probe_dt as well.
>
> Fixes: 06f255106923 ("mtd: remove use of __devinit")
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
Applied to nand/next, thanks!
Miquèl
prev parent reply other threads:[~2018-07-01 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 14:50 [PATCH] mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe_dt Martin Kaiser
2018-06-26 7:10 ` Miquel Raynal
2018-06-26 7:24 ` Boris Brezillon
2018-06-26 7:36 ` Miquel Raynal
2018-06-27 8:55 ` Martin Kaiser
2018-06-27 8:52 ` [PATCH v2] " Martin Kaiser
2018-06-27 9:01 ` Miquel Raynal
2018-06-27 20:47 ` [PATCH v3] " Martin Kaiser
2018-06-27 21:35 ` Boris Brezillon
2018-07-01 18:12 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180701201250.5f93b70e@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin@kaiser.cx \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).