Re: marvell_nand driver fails to suspend

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Daniel,

Daniel Mack <daniel@zonque.org> wrote on Sun, 1 Jul 2018 21:04:58 +0200:

> Hi,
> 
> On Sunday, July 01, 2018 12:18 PM, Daniel Mack wrote:
> > I'm seeing the below error when trying to suspend and resume a PXA3xx
> > machine booted from devicetree with the new nand driver. This used to
> > work fine with the old driver, but admittedly, the only kernel I
> > currently have for reference testing is very old (3.0.4), and many other
> > things regarding nand/mtd have also changed since then.  
> > > The suspend/resume implementation in the old driver used to call into  
> > the ->suspend() and ->resume() functions of its mtd_info children
> > directly, but looking at other drivers, it seems this is no longer
> > needed or wanted. It also cleared all interrupts during resume, but that
> > alone doesn't fix it in my tests.  
> > > I haven't followed the development in that area, so I'd appreciate any  
> > hint on how to fix this regression. I'm happy to test patches.  
> 
> I think I figured it out. Will send a patch.

Good to see you figured it out. Indeed there are no more suspend/resume
callbacks, waiting for your patches to fix this.

Thanks,
Miquèl