From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>
Cc: linux-mtd@lists.infradead.org, Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>
Subject: Re: [PATCH v3 01/11] mtd: rawnand: docg4: fix the probe function error path
Date: Wed, 4 Jul 2018 12:07:39 +0200 [thread overview]
Message-ID: <20180704120739.52fc75a1@xps13> (raw)
In-Reply-To: <20180421180043.18366-2-miquel.raynal@bootlin.com>
Hello,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sat, 21 Apr 2018
20:00:33 +0200:
> nand_release() should not be called on an MTD device that has not been
> registered. While it should work thanks to the checks done in
> mtd_device_unregister() it's a bad practice to cleanup/release
> something that has not previously been initialized/allocated.
>
> Rework the error path to follow this rule.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
This patch is marked applied in patchwork while it is not present
anywhere in the official trees and has probably been forgotten. Applied
on nand/next.
Regards,
Miquèl
next prev parent reply other threads:[~2018-07-04 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 18:00 [PATCH v3 00/11] Fix NAND controllers probe functions error path Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 01/11] mtd: rawnand: docg4: fix the probe function " Miquel Raynal
2018-07-04 10:07 ` Miquel Raynal [this message]
2018-04-21 18:00 ` [PATCH v3 02/11] mtd: rawnand: fsl_elbc: fix " Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 03/11] mtd: rawnand: fsl_ifc: " Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 04/11] mtd: rawnand: fsmc: clean the probe function style Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 05/11] mtd: rawnand: fsmc: fix the probe function error path Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 06/11] mtd: rawnand: hisi504: clean " Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 07/11] mtd: rawnand: hisi504: fix " Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 08/11] mtd: rawnand: lpc32xx_mlc: clean the probe function Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 09/11] mtd: rawnand: lpc32xx_mlc: fix the probe function error path Miquel Raynal
2018-04-21 18:00 ` [PATCH v3 10/11] mtd: rawnand: lpc32xx_slc: clean the probe function Miquel Raynal
2018-04-26 17:26 ` Boris Brezillon
2018-04-21 18:00 ` [PATCH v3 11/11] mtd: rawnand: lpc32xx_slc: fix the probe function error path Miquel Raynal
2018-04-26 19:51 ` [PATCH v3 00/11] Fix NAND controllers probe functions " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704120739.52fc75a1@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=slemieux.tyco@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox