From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Colin King <colin.king@canonical.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nftl: remove redundant variable nb_erases
Date: Sat, 7 Jul 2018 12:04:23 +0200 [thread overview]
Message-ID: <20180707120423.17502c7f@bbrezillon> (raw)
In-Reply-To: <20180704064609.13369-1-colin.king@canonical.com>
On Wed, 4 Jul 2018 07:46:09 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable nb_erases is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'nb_erases' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Boris
> ---
> drivers/mtd/nftlmount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
> index 27184e3874db..91b7fb326f9a 100644
> --- a/drivers/mtd/nftlmount.c
> +++ b/drivers/mtd/nftlmount.c
> @@ -577,7 +577,7 @@ static int get_fold_mark(struct NFTLrecord *nftl, unsigned int block)
> int NFTL_mount(struct NFTLrecord *s)
> {
> int i;
> - unsigned int first_logical_block, logical_block, rep_block, nb_erases, erase_mark;
> + unsigned int first_logical_block, logical_block, rep_block, erase_mark;
> unsigned int block, first_block, is_first_block;
> int chain_length, do_format_chain;
> struct nftl_uci0 h0;
> @@ -621,7 +621,6 @@ int NFTL_mount(struct NFTLrecord *s)
>
> logical_block = le16_to_cpu ((h0.VirtUnitNum | h0.SpareVirtUnitNum));
> rep_block = le16_to_cpu ((h0.ReplUnitNum | h0.SpareReplUnitNum));
> - nb_erases = le32_to_cpu (h1.WearInfo);
> erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1));
>
> is_first_block = !(logical_block >> 15);
prev parent reply other threads:[~2018-07-07 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 6:46 [PATCH] mtd: nftl: remove redundant variable nb_erases Colin King
2018-07-07 10:04 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707120423.17502c7f@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=colin.king@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox