[PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier

[PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c  | 27 +++++++--------------------
 drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 27 +++++++--------------------
 drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h | 11 +----------
 3 files changed, 15 insertions(+), 50 deletions(-)

diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
index 83697b8..5673cb2 100644
--- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
+++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
@@ -1,23 +1,10 @@
-/*
- * Freescale GPMI NAND Flash Driver
- *
- * Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
- * Copyright (C) 2008 Embedded Alley Solutions, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Freescale GPMI NAND Flash Driver
+//
+// Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
+// Copyright (C) 2008 Embedded Alley Solutions, Inc.
+
 #include <linux/delay.h>
 #include <linux/clk.h>
 #include <linux/slab.h>
diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
index f6aa358..ff1453f 100644
--- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
@@ -1,23 +1,10 @@
-/*
- * Freescale GPMI NAND Flash Driver
- *
- * Copyright (C) 2010-2015 Freescale Semiconductor, Inc.
- * Copyright (C) 2008 Embedded Alley Solutions, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Freescale GPMI NAND Flash Driver
+//
+// Copyright (C) 2010-2015 Freescale Semiconductor, Inc.
+// Copyright (C) 2008 Embedded Alley Solutions, Inc.
+
 #include <linux/clk.h>
 #include <linux/slab.h>
 #include <linux/sched/task_stack.h>
diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
index 6aa10d6..69cd0cb 100644
--- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
+++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
@@ -1,18 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Freescale GPMI NAND Flash Driver
  *
  * Copyright (C) 2010-2011 Freescale Semiconductor, Inc.
  * Copyright (C) 2008 Embedded Alley Solutions, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #ifndef __DRIVERS_MTD_NAND_GPMI_NAND_H
 #define __DRIVERS_MTD_NAND_GPMI_NAND_H
-- 
2.7.4

Re: [PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier

[Miquel Raynal]

Hi Fabio,

Fabio Estevam <festevam@gmail.com> wrote on Fri,  6 Jul 2018 14:28:23
-0300:

> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>

Can you please cc: me also when you send NAND patches? thanks!

> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c  | 27 +++++++--------------------
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 27 +++++++--------------------
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h | 11 +----------
>  3 files changed, 15 insertions(+), 50 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> index 83697b8..5673cb2 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> @@ -1,23 +1,10 @@
> -/*
> - * Freescale GPMI NAND Flash Driver
> - *
> - * Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
> - * Copyright (C) 2008 Embedded Alley Solutions, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License along
> - * with this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// Freescale GPMI NAND Flash Driver
> +//
> +// Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
> +// Copyright (C) 2008 Embedded Alley Solutions, Inc.

Maybe I'm not aware of something recent but I thought only the SPDX
license tag was supposed to use '//' comments while the other lines
should be still using '/* */' like any other comments in the code?

I think the rest of this subsystem uses:

// SPDX tag
/*
 *
[...]
 */

Would you mind changing this?

Kind regards,
Miquèl

Re: [PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier

[Fabio Estevam]

Hi Miquel,

On Sat, Jul 7, 2018 at 2:00 PM, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

>> +// SPDX-License-Identifier: GPL-2.0+
>> +//
>> +// Freescale GPMI NAND Flash Driver
>> +//
>> +// Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
>> +// Copyright (C) 2008 Embedded Alley Solutions, Inc.
>
> Maybe I'm not aware of something recent but I thought only the SPDX
> license tag was supposed to use '//' comments while the other lines
> should be still using '/* */' like any other comments in the code?

There are some subsystem maintainers (and also Linus) that prefer
putting everything in // style:
https://lkml.org/lkml/2017/11/25/133

> I think the rest of this subsystem uses:
>
> // SPDX tag
> /*
>  *
> [...]
>  */
>
> Would you mind changing this?

Sure, I can send a v2.

Re: [PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier

[Miquel Raynal]

Hi Fabio,

Fabio Estevam <festevam@gmail.com> wrote on Sat, 7 Jul 2018 14:16:48
-0300:

> Hi Miquel,
> 
> On Sat, Jul 7, 2018 at 2:00 PM, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> >> +// SPDX-License-Identifier: GPL-2.0+
> >> +//
> >> +// Freescale GPMI NAND Flash Driver
> >> +//
> >> +// Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
> >> +// Copyright (C) 2008 Embedded Alley Solutions, Inc.  
> >
> > Maybe I'm not aware of something recent but I thought only the SPDX
> > license tag was supposed to use '//' comments while the other lines
> > should be still using '/* */' like any other comments in the code?  
> 
> There are some subsystem maintainers (and also Linus) that prefer
> putting everything in // style:
> https://lkml.org/lkml/2017/11/25/133

Thanks for the thread!

Well then, next time, just choose your favourite one.

v2 (with the two patches) applied to nand/next.

Thanks,
Miquèl