From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH 1/3] mtd: rawnand: better name for the controller structure
Date: Tue, 17 Jul 2018 13:58:37 +0200 [thread overview]
Message-ID: <20180717135837.29afdbde@xps13> (raw)
In-Reply-To: <20180717134950.69b59136@bbrezillon>
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Tue, 17 Jul 2018
13:49:50 +0200:
> On Tue, 17 Jul 2018 11:54:52 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > In the raw NAND core, a NAND chip is described by a nand_chip structure,
> > while a NAND controller is described with a nand_hw_control structure
> > which is not very meaningful. 'control' is misleading and 'hw' has no
> > meaning here has it refers to hardware ECC operations only,
>
> I don't think hw refers to hardware ECC, but I agree that
> nand_controller is a better name for this structure.
>
> How about dropping the last sentence?
Do you mean, removing
"'control' is misleading [...] which is too restrictive"
or
"Rename this structure nand_controller"
?
>
> > which is too
> > restrictive.
> >
> > Rename this structure nand_controller.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
next prev parent reply other threads:[~2018-07-17 11:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 9:54 [RFC PATCH 0/3] Changes in the internal raw NAND API Miquel Raynal
2018-07-17 9:54 ` [RFC PATCH 1/3] mtd: rawnand: better name for the controller structure Miquel Raynal
2018-07-17 11:49 ` Boris Brezillon
2018-07-17 11:58 ` Miquel Raynal [this message]
2018-07-17 12:05 ` Boris Brezillon
2018-07-17 9:54 ` [RFC PATCH 2/3] mtd: rawnand: update the controller structure initialization function name Miquel Raynal
2018-07-17 11:51 ` Boris Brezillon
2018-07-17 12:01 ` Miquel Raynal
2018-07-17 9:54 ` [RFC PATCH 3/3] mtd: rawnand: add hooks that may be called during nand_scan() Miquel Raynal
2018-07-17 12:03 ` Boris Brezillon
2018-07-17 12:09 ` Miquel Raynal
2018-07-17 12:13 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717135837.29afdbde@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox