From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 0/2] Changes in the internal raw NAND API
Date: Thu, 19 Jul 2018 23:10:16 +0200 [thread overview]
Message-ID: <20180719231016.39e3da4c@xps13> (raw)
In-Reply-To: <20180718231234.8534-1-miquel.raynal@bootlin.com>
> After having sent two versions of a series removing the
> nand_scan_ident/nand_scan_tail limitation that prevents us to allocate
> memory at critical moments, we are still discussing the internal API.
>
> To avoid sending again more than 20 patches, this is an RFC of the
> internal changes prior to the above modifications in each driver:
>
> 1/ Rename struct nand_hw_control -> struct nand_controller which is
> much more meaningful.
> 2/ Rename the function initializing the above structure
> nand_hw_control_init() -> nand_controller_init().
> 3/ Rename the dummy controller implementation in the nand_chip structure
> hwcontrol -> dummy_controller.
> 3/ Create a nand_controller_ops structure which will be embedded in the
> nand_controller structure. These operations are:
> int (*attach_chip)(struct nand_chip *) and
> void (*detach_chip)(struct nand_chip *).
>
> If we agree on this, I could merge them first and then send the bunch of
> patches making use of these API changes.
>
> Thanks,
> Miquèl
>
> Changes since v2:
> =================
> * Reworded the nand_controller structure documentation as suggested.
> * Used Boris' explanation of the introduction of the
> ->attach/detach_chip() hooks.
> * Removed the initialization of controller->ops() in
> nand_controller_init().
> * s/may be called/will be called/ in ->attach/detach_chip()
> documentation line.
> * Also mentioned that ->detach_chip() will be called from
> nand_cleanup().
>
> Changes since v1 (RFC):
> =======================
> * Added Acked-by tags from Boris.
> * Updated the commit logs as commented.
> * Squashed the 2 patches about nand_hw_control and
> nand_init_hw_control().
> * Also added the rename of hwcontrol in patch 1.
> * Added helpers to 1/ check the controller operations are present and
> 2/ ->attach_chip() or ->detach_chip() is available, as suggested by
> Boris.
>
>
> Miquel Raynal (2):
> mtd: rawnand: better name for the controller structure
> mtd: rawnand: add hooks that may be called during nand_scan()
>
> drivers/mtd/nand/raw/atmel/nand-controller.c | 10 ++++----
> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++--
> drivers/mtd/nand/raw/docg4.c | 4 ++--
> drivers/mtd/nand/raw/fsl_elbc_nand.c | 4 ++--
> drivers/mtd/nand/raw/fsl_ifc_nand.c | 4 ++--
> drivers/mtd/nand/raw/jz4780_nand.c | 7 +++---
> drivers/mtd/nand/raw/marvell_nand.c | 6 ++---
> drivers/mtd/nand/raw/mtk_nand.c | 2 +-
> drivers/mtd/nand/raw/nand_base.c | 36 ++++++++++++++++++++++++----
> drivers/mtd/nand/raw/ndfc.c | 4 ++--
> drivers/mtd/nand/raw/omap2.c | 2 +-
> drivers/mtd/nand/raw/oxnas_nand.c | 4 ++--
> drivers/mtd/nand/raw/qcom_nandc.c | 4 ++--
> drivers/mtd/nand/raw/s3c2410.c | 4 ++--
> drivers/mtd/nand/raw/sunxi_nand.c | 6 ++---
> drivers/mtd/nand/raw/tango_nand.c | 4 ++--
> drivers/mtd/nand/raw/tegra_nand.c | 6 ++---
> drivers/mtd/nand/raw/txx9ndfmc.c | 4 ++--
> include/linux/mtd/rawnand.h | 29 +++++++++++++++++-----
> 19 files changed, 95 insertions(+), 49 deletions(-)
>
Series applied to nand/next.
prev parent reply other threads:[~2018-07-19 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 23:12 [PATCH v3 0/2] Changes in the internal raw NAND API Miquel Raynal
2018-07-18 23:12 ` [PATCH v3 1/2] mtd: rawnand: better name for the controller structure Miquel Raynal
2018-07-18 23:12 ` [PATCH v3 2/2] mtd: rawnand: add hooks that may be called during nand_scan() Miquel Raynal
2018-07-26 16:22 ` Stefan Agner
2018-07-26 18:12 ` Boris Brezillon
2018-07-26 22:20 ` Stefan Agner
2018-07-26 22:40 ` Boris Brezillon
2018-07-26 22:47 ` Miquel Raynal
2018-07-26 23:12 ` Miquel Raynal
2018-07-19 6:11 ` [PATCH v3 0/2] Changes in the internal raw NAND API Boris Brezillon
2018-07-19 21:10 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719231016.39e3da4c@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).