* [PATCH] mtd: rawnand: Remove unused caller_is_module() definition
@ 2018-07-19 20:47 Boris Brezillon
2018-07-19 21:12 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Boris Brezillon @ 2018-07-19 20:47 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut
Commit 260e89a6e0d6 ("mtd: core: tone down suggestion that dev.parent
should be set") removed the only user of caller_is_module() but forgot
to remove the definition itself. Let's remove it now.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/nand/raw/nand_base.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 323a900f3697..99d67d7d2f94 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -6718,18 +6718,6 @@ int nand_scan_tail(struct mtd_info *mtd)
}
EXPORT_SYMBOL(nand_scan_tail);
-/*
- * is_module_text_address() isn't exported, and it's mostly a pointless
- * test if this is a module _anyway_ -- they'd have to try _really_ hard
- * to call us from in-kernel code if the core NAND support is modular.
- */
-#ifdef MODULE
-#define caller_is_module() (1)
-#else
-#define caller_is_module() \
- is_module_text_address((unsigned long)__builtin_return_address(0))
-#endif
-
/**
* nand_scan_with_ids - [NAND Interface] Scan for the NAND device
* @mtd: MTD device structure
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: Remove unused caller_is_module() definition
2018-07-19 20:47 [PATCH] mtd: rawnand: Remove unused caller_is_module() definition Boris Brezillon
@ 2018-07-19 21:12 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2018-07-19 21:12 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, linux-mtd, David Woodhouse, Brian Norris,
Marek Vasut
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 19 Jul 2018
22:47:38 +0200:
> Commit 260e89a6e0d6 ("mtd: core: tone down suggestion that dev.parent
> should be set") removed the only user of caller_is_module() but forgot
> to remove the definition itself. Let's remove it now.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
Applied to nand/next.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-19 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 20:47 [PATCH] mtd: rawnand: Remove unused caller_is_module() definition Boris Brezillon
2018-07-19 21:12 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).