From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 20 Jul 2018 09:12:07 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan() Message-ID: <20180720091207.7828147d@xps13> In-Reply-To: <20180720011719.7545fbb9@bbrezillon> References: <20180719230026.8741-1-miquel.raynal@bootlin.com> <20180719230026.8741-2-miquel.raynal@bootlin.com> <20180720011719.7545fbb9@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Boris, Boris Brezillon wrote on Fri, 20 Jul 2018 01:17:19 +0200: > On Fri, 20 Jul 2018 00:59:54 +0200 > Miquel Raynal wrote: >=20 > > + > > +static struct nand_controller_ops brcmnand_controller_ops =3D { =20 >=20 > static const ... Mmmh right, I'll constify every controller_ops definition. >=20 > The same comment applies to all patches of this series. >=20 > > + .attach_chip =3D brcmnand_attach_chip, > > +}; =20 >=20 Miqu=C3=A8l