From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4 2/2] Documentation: mtd: remove stale pxa3xx NAND controller documentation
Date: Sun, 5 Aug 2018 22:04:03 +0200 [thread overview]
Message-ID: <20180805220403.0eaafc8f@bbrezillon> (raw)
In-Reply-To: <87in4o1vlj.fsf@belgarion.home>
Hi Robert,
On Sun, 05 Aug 2018 21:06:48 +0200
Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Miquel Raynal <miquel.raynal@bootlin.com> writes:
>
> > It is preferred to have the documentation about the drivers directly
> > embedded in the driver itself.
> Could you tell me where this statement comes from ?
>
> Because so far I've always been told the opposite.
I complained about that when I inadvertently discovered there was a doc
explaining how the marvell IP works in Documentation/mtd/nand/
(which happened after someone posted a patch series adding a new file
there). That's really something I'd expect to be described inside the
driver directly. I'm perfectly fine having framework documentation or
even SoC documentation placed in Documentation, but when it comes to
driver/IP documentation it's IMO better placed directly in the driver
source code, just because people usually don't look for driver-specific
doc in Documentation/.
A compromise would be to have everything documented in the driver
using overview doc comments [1], and then let sphynx parse this doc
header and generate the proper doc entry, but that's IMHO less important
to have such IP-specific information embedded in the kernel doc.
Regards,
Boris
[1]https://www.kernel.org/doc/html/v4.11/doc-guide/kernel-doc.html#overview-documentation-comments
next prev parent reply other threads:[~2018-08-05 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 14:52 [PATCH v4 1/2] mtd: rawnand: marvell: document a bit more the driver Miquel Raynal
2018-08-05 14:52 ` [PATCH v4 2/2] Documentation: mtd: remove stale pxa3xx NAND controller documentation Miquel Raynal
2018-08-05 19:06 ` Robert Jarzmik
2018-08-05 20:04 ` Boris Brezillon [this message]
2018-08-12 19:54 ` Ezequiel Garcia
2018-08-05 15:04 ` [PATCH v4 1/2] mtd: rawnand: marvell: document a bit more the driver Boris Brezillon
2018-09-04 21:54 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805220403.0eaafc8f@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).