From: Brian Norris <computersforpeace@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
NeilBrown <neilb@suse.com>,
devicetree@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Zhiqiang Hou <Zhiqiang.Hou@nxp.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spi-nor: only apply reset hacks to broken hardware
Date: Tue, 7 Aug 2018 12:22:42 -0700 [thread overview]
Message-ID: <20180807192242.GA139259@ban.mtv.corp.google.com> (raw)
In-Reply-To: <20180807183901.GB31722@rob-hp-laptop>
On Tue, Aug 07, 2018 at 12:39:01PM -0600, Rob Herring wrote:
> On Tue, Jul 31, 2018 at 03:35:50PM -0700, Brian Norris wrote:
> > One reason I didn't specifically say something like "not connected", is
> > because IIUC it's actually *possible* to have a robust boot sequence
> > without the RESET# pin -- e.g., if your boot ROM hardcoded a software
> > reset command (just because it's not really standardized doesn't mean
> > one can't do it).
>
> Based on that, then it sounds like you need a specific compatible string
> so you too can know how to s/w reset the device.
We do also support compatible properties for these chips, where needed.
But I don't think that's really needed.
> I guess you are assuming a bootloader didn't leave the flash in an
> unknown addressing state?
For some of these address states (at least, 3-byte vs. 4-byte
addressing), we can still identify the device independently; the READ ID
command works in either mode.
The problem is that a boot ROM is rarely as complex as a Linux driver
and probably can't be updated. And they usually do stupid things anyway.
So *that's* where you need a well-defined entry state for the flash.
Brian
next prev parent reply other threads:[~2018-08-07 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 18:33 [PATCH] mtd: spi-nor: only apply reset hacks to broken hardware Brian Norris
2018-07-27 19:06 ` Guenter Roeck
2018-07-27 20:03 ` [PATCH] " Boris Brezillon
2018-07-31 1:05 ` NeilBrown
2018-07-31 20:12 ` Boris Brezillon
2018-07-31 22:15 ` Marek Vasut
2018-08-01 0:40 ` NeilBrown
2018-08-01 8:24 ` Marek Vasut
2018-07-31 22:35 ` Brian Norris
2018-08-01 1:06 ` NeilBrown
2018-08-07 18:39 ` Rob Herring
2018-08-07 19:22 ` Brian Norris [this message]
2018-08-01 0:38 ` NeilBrown
2018-08-01 7:15 ` Boris Brezillon
2018-08-07 18:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807192242.GA139259@ban.mtv.corp.google.com \
--to=computersforpeace@gmail.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=boris.brezillon@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=neilb@suse.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox