* [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
@ 2018-08-11 13:47 Boris Brezillon
2018-08-11 14:05 ` Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Boris Brezillon @ 2018-08-11 13:47 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut, Randy Dunlap,
Thomas Petazzoni
The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
build errors when selected through COMPILE_TEST.
Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
Changes in v2:
- Use select instead of depends on (suggested by Thomas)
---
drivers/mtd/nand/raw/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index b6738ece16f1..5fc9a1bde4ac 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -279,6 +279,7 @@ config MTD_NAND_ATMEL
tristate "Support for NAND Flash / SmartMedia on AT91"
depends on ARCH_AT91 || COMPILE_TEST
depends on HAS_IOMEM
+ select GENERIC_ALLOCATOR
select MFD_ATMEL_SMC
help
Enables support for NAND Flash / Smart Media Card interface
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
2018-08-11 13:47 [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR Boris Brezillon
@ 2018-08-11 14:05 ` Miquel Raynal
2018-08-11 14:10 ` Boris Brezillon
2018-08-11 15:11 ` Randy Dunlap
2018-08-12 8:17 ` Boris Brezillon
2 siblings, 1 reply; 5+ messages in thread
From: Miquel Raynal @ 2018-08-11 14:05 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, linux-mtd, David Woodhouse, Brian Norris,
Marek Vasut, Randy Dunlap, Thomas Petazzoni
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Sat, 11 Aug 2018
15:47:12 +0200:
> The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
> build errors when selected through COMPILE_TEST.
>
> Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes in v2:
> - Use select instead of depends on (suggested by Thomas)
> ---
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
That's for your -rc1's fixes PR :)
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
2018-08-11 14:05 ` Miquel Raynal
@ 2018-08-11 14:10 ` Boris Brezillon
0 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2018-08-11 14:10 UTC (permalink / raw)
To: Miquel Raynal
Cc: Richard Weinberger, linux-mtd, David Woodhouse, Brian Norris,
Marek Vasut, Randy Dunlap, Thomas Petazzoni
On Sat, 11 Aug 2018 16:05:24 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Sat, 11 Aug 2018
> 15:47:12 +0200:
>
> > The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
> > build errors when selected through COMPILE_TEST.
> >
> > Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> > Changes in v2:
> > - Use select instead of depends on (suggested by Thomas)
> > ---
>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> That's for your -rc1's fixes PR :)
Actually, I plan to queue it to mtd/next before preparing my PR for
4.19, so it should be in -rc1.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
2018-08-11 13:47 [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR Boris Brezillon
2018-08-11 14:05 ` Miquel Raynal
@ 2018-08-11 15:11 ` Randy Dunlap
2018-08-12 8:17 ` Boris Brezillon
2 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2018-08-11 15:11 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut, Thomas Petazzoni
On 08/11/2018 06:47 AM, Boris Brezillon wrote:
> The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
> build errors when selected through COMPILE_TEST.
>
> Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Changes in v2:
> - Use select instead of depends on (suggested by Thomas)
> ---
> drivers/mtd/nand/raw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index b6738ece16f1..5fc9a1bde4ac 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -279,6 +279,7 @@ config MTD_NAND_ATMEL
> tristate "Support for NAND Flash / SmartMedia on AT91"
> depends on ARCH_AT91 || COMPILE_TEST
> depends on HAS_IOMEM
> + select GENERIC_ALLOCATOR
> select MFD_ATMEL_SMC
> help
> Enables support for NAND Flash / Smart Media Card interface
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
2018-08-11 13:47 [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR Boris Brezillon
2018-08-11 14:05 ` Miquel Raynal
2018-08-11 15:11 ` Randy Dunlap
@ 2018-08-12 8:17 ` Boris Brezillon
2 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2018-08-12 8:17 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut, Randy Dunlap,
Thomas Petazzoni
On Sat, 11 Aug 2018 15:47:12 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
> build errors when selected through COMPILE_TEST.
>
> Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Applied.
> ---
> Changes in v2:
> - Use select instead of depends on (suggested by Thomas)
> ---
> drivers/mtd/nand/raw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index b6738ece16f1..5fc9a1bde4ac 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -279,6 +279,7 @@ config MTD_NAND_ATMEL
> tristate "Support for NAND Flash / SmartMedia on AT91"
> depends on ARCH_AT91 || COMPILE_TEST
> depends on HAS_IOMEM
> + select GENERIC_ALLOCATOR
> select MFD_ATMEL_SMC
> help
> Enables support for NAND Flash / Smart Media Card interface
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-12 8:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-11 13:47 [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR Boris Brezillon
2018-08-11 14:05 ` Miquel Raynal
2018-08-11 14:10 ` Boris Brezillon
2018-08-11 15:11 ` Randy Dunlap
2018-08-12 8:17 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).