From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.bootlin.com ([62.4.15.54])
 by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))
 id 1folZj-00089E-Fx
 for linux-mtd@lists.infradead.org; Sun, 12 Aug 2018 08:18:17 +0000
Date: Sun, 12 Aug 2018 10:17:45 +0200
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>, Richard Weinberger
 <richard@nod.at>, Miquel Raynal <miquel.raynal@bootlin.com>,
 linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>, Brian Norris
 <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Randy
 Dunlap <rdunlap@infradead.org>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
Message-ID: <20180812101745.4e1b518f@bbrezillon>
In-Reply-To: <20180811134712.2903-1-boris.brezillon@bootlin.com>
References: <20180811134712.2903-1-boris.brezillon@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Sat, 11 Aug 2018 15:47:12 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
> build errors when selected through COMPILE_TEST.
> 
> Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Applied.

> ---
> Changes in v2:
> - Use select instead of depends on (suggested by Thomas)
> ---
>  drivers/mtd/nand/raw/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index b6738ece16f1..5fc9a1bde4ac 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -279,6 +279,7 @@ config MTD_NAND_ATMEL
>  	tristate "Support for NAND Flash / SmartMedia on AT91"
>  	depends on ARCH_AT91 || COMPILE_TEST
>  	depends on HAS_IOMEM
> +	select GENERIC_ALLOCATOR
>  	select MFD_ATMEL_SMC
>  	help
>  	  Enables support for NAND Flash / Smart Media Card interface