Re: [PATCH] spi-nor: intel-spi: Add support for Intel Ice Lake SPI serial flash

[Boris Brezillon <boris.brezillon@bootlin.com>]

Hi Marek,

On Tue, 28 Aug 2018 18:56:38 +0200
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 08/28/2018 06:50 PM, Mika Westerberg wrote:
> > Intel Ice Lake exposes the SPI serial flash controller as a PCI device
> > in the same way than Intel Denverton. Add Ice Lake SPI serial flash PCI
> > ID to the driver list of supported devices.
> > 
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>  
> 
> This should probably go through trivial patches ML, no ?

Nope, it should go through the spi-nor tree. Actually, even for trivial
fixes like typos, I prefer to take them directly to avoid possible
future conflicts in case something changes near the typo.

> Also, CC Stable.

Why? It's adding a new entry in pci_ids[] table, it looks like
supporting new HW to me, not fixing a bug.

Regards,

Boris

> 
> > ---
> >  drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
> > index c0976f2e3dd1..872b40922608 100644
> > --- a/drivers/mtd/spi-nor/intel-spi-pci.c
> > +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
> > @@ -65,6 +65,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
> >  static const struct pci_device_id intel_spi_pci_ids[] = {
> >  	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
> >  	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
> > +	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
> >  	{ PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info },
> >  	{ PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
> >  	{ },
> >   
> 
>