From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuywS-0003Ts-I4 for linux-mtd@lists.infradead.org; Wed, 29 Aug 2018 11:48:06 +0000 Date: Wed, 29 Aug 2018 13:46:58 +0200 From: Boris Brezillon To: Marek Vasut Cc: Joakim Tjernlund , "mika.westerberg@linux.intel.com" , "computersforpeace@gmail.com" , "linux-mtd@lists.infradead.org" , "richard@nod.at" , "dwmw2@infradead.org" Subject: Re: [PATCH] spi-nor: intel-spi: Add support for Intel Ice Lake SPI serial flash Message-ID: <20180829134658.1fa24b40@bbrezillon> In-Reply-To: References: <20180828165059.55223-1-mika.westerberg@linux.intel.com> <3261d2da-c0a5-920e-ca12-17924a2d3918@gmail.com> <20180829111740.12223549@bbrezillon> <57933711d93f3ba372ca14743daa90df834ed494.camel@infinera.com> <20180829123306.3e9928a4@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 29 Aug 2018 12:54:22 +0200 Marek Vasut wrote: > On 08/29/2018 12:44 PM, Joakim Tjernlund wrote: > > On Wed, 2018-08-29 at 12:33 +0200, Boris Brezillon wrote: > >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > >> > >> > >> On Wed, 29 Aug 2018 10:28:05 +0000 > >> Joakim Tjernlund wrote: > >> > >>> On Wed, 2018-08-29 at 11:17 +0200, Boris Brezillon wrote: > >>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > >>>> > >>>> > >>>> Hi Marek, > >>>> > >>>> On Tue, 28 Aug 2018 18:56:38 +0200 > >>>> Marek Vasut wrote: > >>>> > >>>>> On 08/28/2018 06:50 PM, Mika Westerberg wrote: > >>>>>> Intel Ice Lake exposes the SPI serial flash controller as a PCI device > >>>>>> in the same way than Intel Denverton. Add Ice Lake SPI serial flash PCI > >>>>>> ID to the driver list of supported devices. > >>>>>> > >>>>>> Signed-off-by: Mika Westerberg > >>>>> > >>>>> This should probably go through trivial patches ML, no ? > >>>> > >>>> Nope, it should go through the spi-nor tree. Actually, even for trivial > >>>> fixes like typos, I prefer to take them directly to avoid possible > >>>> future conflicts in case something changes near the typo. > >>>> > >>>>> Also, CC Stable. > >>>> > >>>> Why? It's adding a new entry in pci_ids[] table, it looks like > >>>> supporting new HW to me, not fixing a bug. > >>> > >>> So you can boot/use new HW with stable kernels. Stable kernels would become > >>> useless fairly quickly otherwise. > >>> HW enablement patches are OK when they don't affect existing HW by much. > >> > >> Where did you get that from? I've always been told that Cc-ing stable > >> was reserved for bug fixes. > > > > From following linux dev lists. I don't have a reference, sorry. > > > > If you look at the commit log for stable kernels you will see that a lot more > > than pure bug fixes. Sometimes backport of new infra structure to > > allow for easy backporting of fixes too. > > Documentation/process/stable-kernel-rules.rst > 24 - New device IDs and quirks are also accepted. > > Okay. I didn't know that. Thanks, Boris