From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 3 Sep 2018 10:36:00 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur Cc: Lothar =?UTF-8?B?V2HDn21hbm4=?= , "linux-mtd@lists.infradead.org" , "marek.vasut@gmail.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" , "mark.rutland@arm.com" , "robh@kernel.org" , "linux-kernel@vger.kernel.org" , "frieder.schrempf@exceet.de" , "computersforpeace@gmail.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/7] spi: add slave device size in spi_device struct Message-ID: <20180903103600.3efabbac@bbrezillon> In-Reply-To: References: <1535711404-29528-1-git-send-email-yogeshnarayan.gaur@nxp.com> <1535711404-29528-2-git-send-email-yogeshnarayan.gaur@nxp.com> <20180831135807.22255bce@karo-electronics.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Yogesh, On Mon, 3 Sep 2018 04:47:25 +0000 Yogesh Narayan Gaur wrote: > Hi Lothar, >=20 > > -----Original Message----- > > From: Lothar Wa=C3=9Fmann [mailto:LW@KARO-electronics.de] > > Sent: Friday, August 31, 2018 5:28 PM > > To: Yogesh Narayan Gaur > > Cc: linux-mtd@lists.infradead.org; boris.brezillon@bootlin.com; > > marek.vasut@gmail.com; linux-spi@vger.kernel.org; > > devicetree@vger.kernel.org; mark.rutland@arm.com; robh@kernel.org; linu= x- > > kernel@vger.kernel.org; frieder.schrempf@exceet.de; > > computersforpeace@gmail.com; shawnguo@kernel.org; linux-arm- > > kernel@lists.infradead.org > > Subject: Re: [PATCH 1/7] spi: add slave device size in spi_device struct > >=20 > > Hi, > >=20 > > On Fri, 31 Aug 2018 15:59:58 +0530 Yogesh Gaur wrote: =20 > > > Add 'size' data variable in spi_device struct. > > > This is to save the size of the connected slave device. > > > > > > After slave device scan, spi_nor_scan, size being assigned to this > > > from MTD layer. > > > > > > SFDP read is being requested before completion of spi_nor_scan() > > > routine, thus populate device size before making read request to the > > > SPI controller. > > > > > > Signed-off-by: Yogesh Gaur > > > --- > > > drivers/mtd/devices/m25p80.c | 6 ++++++ > > > drivers/mtd/spi-nor/spi-nor.c | 2 ++ > > > include/linux/spi/spi.h | 2 ++ > > > 3 files changed, 10 insertions(+) > > > > > > diff --git a/drivers/mtd/devices/m25p80.c > > > b/drivers/mtd/devices/m25p80.c index fe260cc..6c7ad86 100644 > > > --- a/drivers/mtd/devices/m25p80.c > > > +++ b/drivers/mtd/devices/m25p80.c > > > @@ -124,6 +124,10 @@ static ssize_t m25p80_read(struct spi_nor *nor, = =20 > > loff_t from, size_t len, =20 > > > /* convert the dummy cycles to the number of bytes */ > > > op.dummy.nbytes =3D (nor->read_dummy * op.dummy.buswidth) / 8; > > > > > > + /* for case of SFDP header read commands, populate spi device size = */ > > > + if (flash->spimem->spi->size =3D=3D 0) > > > + flash->spimem->spi->size =3D nor->mtd.size; > > > + =20 > > If the 'size' is an spimem specific variable it should be added to the = spi_mem > > struct rather than the spi_device struct. =20 >=20 > Sure, would move 'size' from struct spi_device to the struct spi_mem. Before you send a new version doing that, I'd like to understand why you need this information. Can you wait a bit so I have some time to review the driver? Thanks, Boris