linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Bernhard Frauendienst <kernel@nospam.obeliks.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 3/3] mtd: mtdconcat: add dt driver for concat devices
Date: Fri, 7 Sep 2018 15:13:01 +0200	[thread overview]
Message-ID: <20180907151301.3a25f7e4@xps13> (raw)
In-Reply-To: <345a1f1e-23e8-d7b5-02f5-5b2ae0ec7209@nospam.obeliks.de>

Hi Bernhard,

Bernhard Frauendienst <kernel@nospam.obeliks.de> wrote on Fri, 7 Sep
2018 00:54:01 +0200:

> Hi Miquel,
> 
> thanks for your review, I've applied most of your suggested changes, except:
> 
> On 06/09/18 20:47, Miquel Raynal wrote:
> >  
> >> +static int virt_concat_remove(struct platform_device *pdev)
> >> +{
> >> +	struct of_virt_concat *info;
> >> +	int i;
> >> +
> >> +	info = platform_get_drvdata(pdev);
> >> +	if (!info)
> >> +		return 0;
> >> +	platform_set_drvdata(pdev, NULL);  
> > Is this really useful?  
> I believe this is indeed useful, as `virt_concat_remove()` is also called as cleanup in error cases of `virt_concat_probe()`. Then it seems to be common practice to unset the driver data from the device.
> 
> Am I mistaken here?

That's fine for me. Perhaps you can explain it with a comment.

I'm pretty sure there will be other "deeper" reviews coming on the
series.

Thanks,
Miquèl

  reply	other threads:[~2018-09-07 13:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 16:14 [PATCH 0/3] Virtual MTD concat device driver Bernhard Frauendienst
2018-09-06 16:14 ` [PATCH 1/3] mtd: core: add get_mtd_device_by_node Bernhard Frauendienst
2018-09-06 18:23   ` Miquel Raynal
2018-09-06 16:14 ` [PATCH 2/3] dt-bindings: add bindings for mtd-concat devices Bernhard Frauendienst
2018-09-06 16:14 ` [PATCH 3/3] mtd: mtdconcat: add dt driver for concat devices Bernhard Frauendienst
2018-09-06 18:47   ` Miquel Raynal
2018-09-06 22:54     ` Bernhard Frauendienst
2018-09-07 13:13       ` Miquel Raynal [this message]
2018-09-06 20:59 ` [PATCH 0/3] Virtual MTD concat device driver Boris Brezillon
2018-09-06 21:03   ` Boris Brezillon
2018-09-06 21:19     ` Bernhard Frauendienst
     [not found]     ` <d8c4e901-ae96-965c-0d01-4fa012da41b8@nospam.obeliks.de>
2018-09-06 21:23       ` Boris Brezillon
2018-09-06 21:35         ` Bernhard Frauendienst
2018-09-06 21:11 ` Boris Brezillon
2018-09-06 21:32   ` Bernhard Frauendienst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907151301.3a25f7e4@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=kernel@nospam.obeliks.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).