From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH v2] mtd: spi-nor: Use DMA-safe buffer for JEDEC ID in spi_nor_read_id()
Date: Mon, 17 Sep 2018 10:46:33 +0200 [thread overview]
Message-ID: <20180917104633.5a18bcd1@bbrezillon> (raw)
In-Reply-To: <08b87712-b018-e448-21b5-aa7c3c7b82cc@linux.intel.com>
On Mon, 17 Sep 2018 11:41:31 +0300
Jarkko Nikula <jarkko.nikula@linux.intel.com> wrote:
> On 09/17/2018 11:28 AM, Boris Brezillon wrote:
> >
> > Hm, I just had a look at all ->read/write_reg() call sites and it seems
> > we have the same problem in other places. Maybe it's just better to fix
> > the problem in m25p80 ->read/write_reg() implems for now and see how we
> > can fix that generically afterwards.
> >
> It's not only m25p80, how about all other cases calling spi_nor_scan()?
>
I agree, the problem is more generic than that, but commit 4120f8d158ef
only breaks the m25p80 driver, and I'd like to keep the fix as simple as
possible.
We can also discuss how to fix that generically, but I'd like the fix
to be merged in 4.19.
next prev parent reply other threads:[~2018-09-17 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 8:10 [PATCH v2] mtd: spi-nor: Use DMA-safe buffer for JEDEC ID in spi_nor_read_id() Jarkko Nikula
2018-09-17 8:18 ` Boris Brezillon
2018-09-17 8:28 ` Boris Brezillon
2018-09-17 8:41 ` Jarkko Nikula
2018-09-17 8:46 ` Boris Brezillon [this message]
2018-09-17 9:04 ` Jarkko Nikula
2018-09-17 12:28 ` Boris Brezillon
2018-09-17 12:51 ` Jarkko Nikula
2018-09-17 12:59 ` Boris Brezillon
2018-09-17 13:37 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917104633.5a18bcd1@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).