From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g1tjF-0000fg-FY for linux-mtd@lists.infradead.org; Mon, 17 Sep 2018 13:38:20 +0000 Date: Mon, 17 Sep 2018 15:37:56 +0200 From: Boris Brezillon To: Jarkko Nikula Cc: Marek Vasut , Brian Norris , linux-mtd@lists.infradead.org, David Woodhouse , Richard Weinberger Subject: Re: [PATCH v2] mtd: spi-nor: Use DMA-safe buffer for JEDEC ID in spi_nor_read_id() Message-ID: <20180917153756.49d1d7b7@bbrezillon> In-Reply-To: <870a6721-620c-a73c-82f9-014fdb02cd6c@linux.intel.com> References: <20180917081018.14475-1-jarkko.nikula@linux.intel.com> <20180917101851.3d359d18@bbrezillon> <20180917102821.16c69697@bbrezillon> <08b87712-b018-e448-21b5-aa7c3c7b82cc@linux.intel.com> <20180917104633.5a18bcd1@bbrezillon> <03fe4a2a-2b74-b4b9-b143-9a1ef5cb4907@linux.intel.com> <20180917142857.16be0331@bbrezillon> <870a6721-620c-a73c-82f9-014fdb02cd6c@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 17 Sep 2018 15:51:24 +0300 Jarkko Nikula wrote: > On 09/17/2018 03:28 PM, Boris Brezillon wrote: > > On Mon, 17 Sep 2018 12:04:43 +0300 > > Jarkko Nikula wrote: > > > >> On 09/17/2018 11:46 AM, Boris Brezillon wrote: > >>> On Mon, 17 Sep 2018 11:41:31 +0300 > >>> Jarkko Nikula wrote: > >>> > >>>> On 09/17/2018 11:28 AM, Boris Brezillon wrote: > >>>>> > >>>>> Hm, I just had a look at all ->read/write_reg() call sites and it seems > >>>>> we have the same problem in other places. Maybe it's just better to fix > >>>>> the problem in m25p80 ->read/write_reg() implems for now > > > > Do you plan to send a new fix doing that, or should I? I'd really like > > to have the fix queued to mtd/master early this week, so that it > > spends a bit of time in -next. > > > I guess better if you could as I haven't started anything yet. I just sent a fix. Would be great if you could test it (and add your Tested-by if it works). Thanks, Boris