From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.iluvatar.ai ([58.213.90.100]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2nbr-0004ok-0z for linux-mtd@lists.infradead.org; Thu, 20 Sep 2018 01:18:26 +0000 Date: Thu, 20 Sep 2018 09:17:59 +0800 From: Huang Shijie To: Lukasz Majewski Cc: Frieder Schrempf , Fabio Estevam , Han Xu , David Wolfe , Yogesh Narayan Gaur , Boris Brezillon , "richard@nod.at" , Prabhakar Kushwaha , "shawnguo@kernel.org" , "linux-spi@vger.kernel.org" , "marek.vasut@gmail.com" , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "miquel.raynal@bootlin.com" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , Albert ARIBAUD Subject: Re: Questions about the Freescale/NXP QuadSPI controller Message-ID: <20180920011759.GA19040@hsj-Precision-5520> References: <20180804153728.0a99d28f@bbrezillon> <121b89ad-712f-166b-83d2-6b0f1bdc750e@exceet.de> <09d39759-390a-bca3-caeb-2ee8ddb29443@exceet.de> <20180919004247.60c6099a@jawa> <20180919130211.3f2e7e3a@jawa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919130211.3f2e7e3a@jawa> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 19, 2018 at 01:02:11PM +0200, Lukasz Majewski wrote: > Hi Frieder, > > > Hi Lukasz, > > > > On 19.09.2018 00:42, Lukasz Majewski wrote: > > > Dear All, > > > > > > Maybe I do jump a bit off topic here, but... > > > > > > I've read through the following thread: > > > https://patchwork.ozlabs.org/patch/939885/ > > > > > > And it mentions some issues with reading AHB content (buffers) in > > > fsl-quadspi.c driver discovered when new QuadSPI driver was > > > developed. > > > > The only setup with two chips that is known to be problematic with > > the new driver, is when both chips are connected to the same bus > > (e.g. QSPIA) using separate chip selects. > > I'm using QSPI0 controller, with two memories connected to QSPI0_A and > QSPI0_B lines. > > > > > Does your board use this kind of setup, or are the two chips > > connected two different buses (QSPIA and QSPIB)? > > > > Have you tested the new driver? It would be great to receive some > > more feedback. > > I will check (test) this new driver. No problem. > > > > > > I do have a setup with qspi0 having two SPI memories connected (2x16 > > > MiB), and I'm wondering if anybody has some more info regarding: > > > > > > (What's more is that there is a bug in > > > * the "IP Command Read" in the Vybrid.) found here: > > > https://elixir.bootlin.com/linux/v4.19-rc4/source/drivers/mtd/spi-nor/fsl-quadspi.c#L671 > > > > > > I've googled for some errata or known issues for vybryd's QSPI IP > > > block (vf610) but without luck so far ... > > > > Unfortunately I don't know the background for this comment. > > The comment was added by some Freescale employee when the driver was > added to Linux (by Huang - CC'ed). I was told that there was a hardware bug in the vybryd when we use the "IP Command Read": If you use the "IP Command Read", you will not get the correct data. So I added that comment. I suggest that do not use the "IP Command Read" for vybryd. Thanks Huang Shijie > > > Is your > > board using VF610? > > Yes, it uses vf610 (A5 + M4 cores). >