From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Daniel Mack <daniel@zonque.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
linux-mtd@lists.infradead.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: Trouble with new marvell_nand driver on PXA3xx
Date: Mon, 24 Sep 2018 09:20:31 +0200 [thread overview]
Message-ID: <20180924092031.3d4af408@xps13> (raw)
In-Reply-To: <f3cf564d-7976-5b2e-ca07-ea872c165396@zonque.org>
Hi Daniel,
Daniel Mack <daniel@zonque.org> wrote on Mon, 24 Sep 2018 08:45:44
+0200:
> Hi Miquel,
>
> I'm having issues using the new marvell_nand driver on a PXA3xx based platform. My test does a ubiformat on the chip, then creates a volume, mounts it and runs bonnie++ on the file system. After some time (usually less than half a minute), the driver spits out a warning like the one below, and eventually the UBI layer bails out, which leads to a r/o remount and (possibly) file system corruptions.
>
> FWIW, this is the test script I'm using:
>
> > #!/bin/sh
> >
> > UBIDEV=0
> > UBIMTD=3
> >
> > umount /mnt
> > ubidetach /dev/ubi_ctrl -d $UBIDEV
> > ubiformat -y /dev/mtd$UBIMTD
> > ubiattach /dev/ubi_ctrl -d $UBIDEV -m $UBIMTD
> > ubimkvol /dev/ubi$UBIDEV -N test -m
> > mount -t ubifs ubi0:test /mnt
> > bonnie\+\+ -d /mnt -u 0:0
>
>
> The legacy pxa3xx_nand driver didn't have this issue, but my system was also running a much older kernel with that. I'm currently still struggling to resurrect the old code, but I'm running into "Wait time out!!!" conditions immediately right now. Not sure what's going on.
>
> Interestingly, I can't seem to reproduce the bug with any of the mtd kernel tests, I've tried all of them, several times, and all succeed. So a file system test that includes the UBI/UBIFS layers seems to trigger different things in the driver than the the tests that operate on the mtd device directly.
>
> I'v also tried this with and without the keep-config DT property, but that didn't change anything.
>
> Could you try my script on some other device that runs the new driver and see if you can reproduce? If bonnie++ is unavailable, extracting a bigger tarball a couple of times will also trigger the bug at some point.
>
> Meanwhile, I can start poking around in the driver. I'd be grateful for a hint on where to start.
>
Interesting, thanks for the feedback.
Right now I have no idea of what happens, but you might want to add a
dump_stack() at the "Timeout waiting for RB signal" error to see what
path in the driver failed.
You might also try with and without DMA?
I'll try to take the time this week to check if it is pxa-related by
testing this on an armada board.
Thanks,
Miquèl
next prev parent reply other threads:[~2018-09-24 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 6:45 Trouble with new marvell_nand driver on PXA3xx Daniel Mack
2018-09-24 7:20 ` Miquel Raynal [this message]
2018-09-24 8:14 ` Daniel Mack
2018-09-24 19:57 ` Daniel Mack
2018-09-24 8:09 ` Boris Brezillon
2018-09-24 8:30 ` Daniel Mack
2018-09-24 9:04 ` Boris Brezillon
2018-09-26 21:19 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924092031.3d4af408@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=daniel@zonque.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox