From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 Oct 2018 11:10:30 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur Cc: Vignesh R , Marek Vasut , Rob Herring , Brian Norris , Linux ARM Mailing List , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "juliensu@mxic.com.tw" , "zhengxunli@mxic.com.tw" , "masonccyang@mxic.com.tw" Subject: Re: [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba Message-ID: <20181004111030.4ae3670c@bbrezillon> In-Reply-To: References: <20181003165603.2579-1-vigneshr@ti.com> <20181003165603.2579-2-vigneshr@ti.com> <20181004093925.2961d881@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 4 Oct 2018 08:47:33 +0000 Yogesh Narayan Gaur wrote: > >=20 > > Yogesh, you already sent "spi: add flags for octal I/O data > > transfer" [3] which is only adding the new OCTAL flags but is not > > patching spi.c and spi-mem.c to take those new flags into account. > > Here is my version of this patch [2] (it's still missing an update > > of SPI_MEM_MAX_BUSWIDTH). Let me know what you want to do (rework > > your version to address the problem or take mine).=20 > I haven't said that I have sent the patches. Well, you at least sent one of them, I know it because I was in CC :P. > My patches are ready and needed to be sent for review. I initially told you to drop those patches because we didn't have a user yet, that's about to change, so I guess we're all good. > In these patches, I am adding support for X-X-X protocol for octal > support and integrating them with spi and flash m25p80 interface. =46rom what I've seen you're not adding support of 8-8-8 but for 1-8-8 an 1-1-8, which is a lot easier to deal with (it's completely stateless, which is what the spi-nor expects). Unless you're talking about other patches you haven't sent yet...