From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 Oct 2018 10:35:08 -0400 From: Sowmini Varadhan To: Arnd Bergmann Cc: Bartosz Golaszewski , Florian Fainelli , Brian Norris , David Miller , Jonathan Corbet , Sekhar Nori , Kevin Hilman , Russell King - ARM Linux , gregkh , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Grygorii Strashko , Srinivas Kandagatla , naren.kernel@gmail.com, Mauro Carvalho Chehab , Andrew Morton , Lukas Wunner , Dan Carpenter , ivan.khoronzhuk@linaro.org, svendev@arcx.com, pabeni@redhat.com, Alban Bedel , Rob Herring , David Lechner , Andrew Lunn , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux ARM , Linux I2C , linux-mtd , linux-omap , Networking , Bartosz Golaszewski , Brian Norris Subject: Re: [PATCH v2 00/29] at24: remove at24_platform_data Message-ID: <20181004143508.GG13299@oracle.com> References: <20180810080526.27207-1-brgl@bgdev.pl> <20180831194643.GA62862@ban.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Just catching up on this thread, so please excuse any unintentional misquotes here. > > > > David: I couldn't find a place in sparc code where any ethernet device > > > > would be registered, so is there a chance that nobody is using it? > > > > > > SPARC uses a true Open Firmware implementation, so it would register > > > drivers through the CONFIG_OF infrastructure. correct > The calls are not even that old, and clearly added intentionally for sparc, > see commit ba94272d08a7 ("i40e: use eth_platform_get_mac_address()") > which added the first one. Yes, correct again. Wouldn't PPC also end up doing the same thing? See also commit c762dff24c06 (for ixgbe) - without this fix sparc systems will come up with a bogus mac address and then you end up having to manually fix this in ugly ways. --Sowmini