public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Robert Marko <robimarko@gmail.com>
Cc: linux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: spinand: winbond: Add support for W25N01GV
Date: Fri, 12 Oct 2018 11:04:12 +0200	[thread overview]
Message-ID: <20181012110412.000a932c@bbrezillon> (raw)
In-Reply-To: <20181006153642.10376-1-robimarko@gmail.com>

+Miquel

Hi Robert,

Please Cc the NAND mantainers when you send a NAND related patch
(in case you don't know about it already, scripts/get_maintainer.pl
should help you find who to Cc).

On Sat,  6 Oct 2018 17:36:42 +0200
Robert Marko <robimarko@gmail.com> wrote:

> W25N01GV is a single die version of the already supported
> W25M02GV with half the capacity. Everything else is the
> same so introduce support for W25N01GV.
> 
> Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf
> 
> Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Looks good.

Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>

> ---
>  drivers/mtd/nand/spi/winbond.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> --- a/drivers/mtd/nand/spi/winbond.c
> +++ b/drivers/mtd/nand/spi/winbond.c
> @@ -84,6 +84,14 @@ static const struct spinand_info winbond
>  		     0,
>  		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL),
>  		     SPINAND_SELECT_TARGET(w25m02gv_select_target)),
> +	SPINAND_INFO("W25N01GV", 0xAA,
> +		     NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1),
> +		     NAND_ECCREQ(1, 512),
> +		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> +					      &write_cache_variants,
> +					      &update_cache_variants),
> +		     0,
> +		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)),
>  };
>  
>  /**
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2018-10-12  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-06 15:36 [PATCH] mtd: spinand: winbond: Add support for W25N01GV Robert Marko
2018-10-12  9:04 ` Boris Brezillon [this message]
2018-10-12 11:03   ` Robert Marko
2018-11-11 20:52   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012110412.000a932c@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=robimarko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox