RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

Yogesh Narayan Gaur
2018-10-22T08:32:21Z

HI,

> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> Sent: Monday, October 22, 2018 1:32 PM
> To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>; Tudor Ambarus
> <tudor.ambarus@microchip.com>; marek.vasut@gmail.com;
> dwmw2@infradead.org; computersforpeace@gmail.com; richard@nod.at;
> linux-kernel@vger.kernel.org; nicolas.ferre@microchip.com;
> cyrille.pitchen@microchip.com; linux-mtd@lists.infradead.org; linux-arm-
> kernel@lists.infradead.org; Cristian.Birsan@microchip.com; Mark Brown
> <broonie@kernel.org>
> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI
> NOR flash memories
>
> On Mon, 22 Oct 2018 06:04:13 +0000
> Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
>
> > -static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const
> > u32 *smpt)
> > +static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const
> > +u32 *smpt, u32 smpt_len)
> > {
> > const u32 *ret = NULL;
> > - u32 i, addr;
> > + u32 i, addr, nmaps;
> > int err;
> > u8 addr_width, read_opcode, read_dummy;
> > u8 read_data_mask, data_byte, map_id;
> > + bool map_id_is_valid = false;
> >
> > addr_width = nor->addr_width;
> > read_dummy = nor->read_dummy;
> > read_opcode = nor->read_opcode;
> >
> > + for (i = 0; i<smpt_len; i++)
> > + pr_info("%s:%i smpt[%d]=%08x\n", __func__, __LINE__,
> > + i, smpt[i]);
> > +
> > map_id = 0;
> > - i = 0;
> > /* Determine if there are any optional Detection Command Descriptors */
> > - while (!(smpt[i] & SMPT_DESC_TYPE_MAP)) {
> > + for (i = 0; i< smpt_len; i++) {
> > + if (!(smpt[i] & SMPT_DESC_TYPE_MAP))
> > + break;
> > +
> > read_data_mask = SMPT_CMD_READ_DATA(smpt[i]);
> > nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]);
> > nor->read_dummy = spi_nor_smpt_read_dummy(nor,
> > smpt[i]);
>
> Could you also print the ->addr_width, ->read_dummy and ->read_opcode here?
>
It didn't showing any print messages here, did above line " if (!(smpt[i] & SMPT_DESC_TYPE_MAP))" also needs to be changes to " if ((smpt[i] & SMPT_DESC_TYPE_MAP))"?

Below is the log, with the suggested change of modifying as
> + for (nmaps = 0; nmaps< smpt_len; nmaps++) {
> + if((smpt[nmaps] & SMPT_DESC_TYPE_MAP))

[ 1.625992] m25p80 spi0.0: found s25fl512s, expected m25p80
[ 1.631681] spi_nor_get_map_in_use:2880 smpt[0]=08ff65fc
[ 1.636988] spi_nor_get_map_in_use:2880 smpt[1]=00000004
[ 1.642292] spi_nor_get_map_in_use:2880 smpt[2]=04ff65fc
[ 1.647596] spi_nor_get_map_in_use:2880 smpt[3]=00000002
[ 1.652898] spi_nor_get_map_in_use:2880 smpt[4]=02ff65fd
[ 1.658200] spi_nor_get_map_in_use:2880 smpt[5]=00000004
[ 1.663503] spi_nor_get_map_in_use:2880 smpt[6]=ff0201fe
[ 1.668806] spi_nor_get_map_in_use:2880 smpt[7]=00007ff1
[ 1.674108] spi_nor_get_map_in_use:2880 smpt[8]=00037ff4
[ 1.679412] spi_nor_get_map_in_use:2880 smpt[9]=03fbfff4
[ 1.684715] spi_nor_get_map_in_use:2880 smpt[10]=ff0203fe
[ 1.690105] spi_nor_get_map_in_use:2880 smpt[11]=03fbfff4
[ 1.695495] spi_nor_get_map_in_use:2880 smpt[12]=00037ff4
[ 1.700886] spi_nor_get_map_in_use:2880 smpt[13]=00007ff1
[ 1.706275] spi_nor_get_map_in_use:2880 smpt[14]=ff0005ff
[ 1.711664] spi_nor_get_map_in_use:2880 smpt[15]=03fffff4
[ 1.717053] spi_nor_get_map_in_use:2910 NO map_id
[ 1.721777] m25p80 spi0.0: s25fl512s (65536 Kbytes)

Didn't throw any return error.

--
Regards,
Yogesh Gaur

> > @@ -2894,18 +2900,35 @@ static const u32 *spi_nor_get_map_in_use(struct
> spi_nor *nor, const u32 *smpt)
> > * Configuration that is currently in use.
> > */
> > map_id = map_id << 1 | !!(data_byte & read_data_mask);
> > + map_id_is_valid = true;
> > i = i + 2;
> > }