Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

Boris Brezillon
2018-10-22T10:25:16Z

On Mon, 22 Oct 2018 10:17:58 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:

> It works,

Not really.

> [ 1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80
> [ 1.633854] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000]
> [ 1.640811] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
> [ 1.646117] spi_nor_get_map_in_use:2882 smpt[1]=00000004
> [ 1.651421] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc
> [ 1.656724] spi_nor_get_map_in_use:2882 smpt[3]=00000002
> [ 1.662028] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd
> [ 1.667331] spi_nor_get_map_in_use:2882 smpt[5]=00000004
> [ 1.672635] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe
> [ 1.677937] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1
> [ 1.683240] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4
> [ 1.688542] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4
> [ 1.693845] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe
> [ 1.699234] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4
> [ 1.704625] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4
> [ 1.710014] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1
> [ 1.715403] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff
> [ 1.720791] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4
> [ 1.726180] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065]

There's still a problem here: you should see this trace 3 times since
we have 3 command descriptors. And of course, the addr_width and
read_dummy are wrong.

> [ 1.733320] spi_nor_get_map_in_use:2912 map_id=0 smpt_len:16 i=:3
> [ 1.739406] End [addr_width:00000000, read_dumy:08, read_opcode:00000065]
> [ 1.746204] m25p80 spi0.0: s25fl512s (65536 Kbytes)