Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

Boris Brezillon
2018-10-22T10:20:48Z

On Mon, 22 Oct 2018 10:03:55 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:

> [ 1.624684] m25p80 spi0.0: found s25fl512s, expected m25p80
> [ 1.630377] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000]
> [ 1.637335] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
> [ 1.642641] spi_nor_get_map_in_use:2882 smpt[1]=00000004
> [ 1.647945] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc
> [ 1.653248] spi_nor_get_map_in_use:2882 smpt[3]=00000002
> [ 1.658551] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd
> [ 1.663855] spi_nor_get_map_in_use:2882 smpt[5]=00000004
> [ 1.669158] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe
> [ 1.674461] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1
> [ 1.679766] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4
> [ 1.685070] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4
> [ 1.690375] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe
> [ 1.695768] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4
> [ 1.701158] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4
> [ 1.706550] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1
> [ 1.711940] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff
> [ 1.717330] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4
> [ 1.722720] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065]

Okay, so addr_width is wrong here (I guess read_dummy is wrong too).
That's probably because we fall in the SMPT_CMD_ADDRESS_LEN_USE_CURRENT
case and nor->addr_width has not yet been initialize when we reach this
function.

> [ 1.729861] spi_nor_get_map_in_use:2912 map_id=1
>
>

[...]

> + for (i = 0; i<smpt_len; i++)
> + pr_info("%s:%i smpt[%d]=%08x\n", __func__, __LINE__, i, smpt[i]);
> +
> map_id = 0;
> - i = 0;
> /* Determine if there are any optional Detection Command Descriptors */
> - while (!(smpt[i] & SMPT_DESC_TYPE_MAP)) {
> + for (i = 0; i< smpt_len; i++) {
> + if ((smpt[i] & SMPT_DESC_TYPE_MAP))
> + break;
> +
> read_data_mask = SMPT_CMD_READ_DATA(smpt[i]);
> nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]);
> nor->read_dummy = spi_nor_smpt_read_dummy(nor, smpt[i]);
> nor->read_opcode = SMPT_CMD_OPCODE(smpt[i]);
> + pr_info("smpt[%d]=[addr_width:%08x, read_dumy:%0x8, read_opcode:%08x]\n", i, nor->addr_width, nor->read_dummy, nor->read_opcode);

^ %08x