From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gEaSa-0001xS-TX for linux-mtd@lists.infradead.org; Mon, 22 Oct 2018 13:41:34 +0000 Date: Mon, 22 Oct 2018 15:41:10 +0200 From: Boris Brezillon To: Linus Walleij Cc: David Woodhouse , Brian Norris , Mark Vasut , Richard Weinberger , linux-mtd@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ricardo Ribalda Delgado Subject: Re: [PATCH v2 00/15] mtd: maps: physmap cleanups Message-ID: <20181022154110.62c0e178@bbrezillon> In-Reply-To: References: <20181019074908.13226-1-boris.brezillon@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Linus, On Mon, 22 Oct 2018 13:45:49 +0200 Linus Walleij wrote: > On Fri, Oct 19, 2018 at 9:49 AM Boris Brezillon > wrote: > > > This is an attempt at merging physmap_of.c, gpio-addr-flash.c and > > physmap.c. The rational behind this decision is code sharing and > > consistency with what's done in other parts of the kernel: > > > > - physmap_of is just adding OF/DT support to the physmap logic, and we > > usually put that code in the pre-existing driver instead of creating > > a new one > > > > - gpio-addr-flash is just an extension of the physmap logic which is > > needed when the platform does not have enough native ADDR lines > > to address the whole flash. Again, I think this core belongs in the > > physmap driver > > > > Patches 1 to 9 are just cleanups, and are not really related to the > > merging of physmap_of and gpio-addr-flash into physmap.c. > > > > Patch 10 to 13 are doing the actual merging work, and patch 14 is > > documenting the addr-gpios property that has been added to support > > the gpio-addr-flash on DT platforms. > > > > Patch 15 is a cosmetic change proposed by Ricardo. > > This series: > Acked-by: Linus Walleij > > I expect to test the result when rebasing my patches for Gemini, > so hope for this to hit your devel branch after v4.20-rc1. > I already have a topic branch [1] in case you want to start working on it before 4.20-rc1. Regards, Boris [1]https://github.com/bbrezillon/linux-0day/tree/mtd/physmap-cleanup