From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>, Han Xu <han.xu@nxp.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Xiaolei Li <xiaolei.li@mediatek.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Stefan Agner <stefan@agner.ch>
Subject: Re: [PATCH 06/15] mtd: rawnand: Add nand_[de]select_target() helpers
Date: Mon, 29 Oct 2018 14:36:47 +0100 [thread overview]
Message-ID: <20181029143647.2efe60cb@xps13> (raw)
In-Reply-To: <20181023185011.3356-7-boris.brezillon@bootlin.com>
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Tue, 23 Oct 2018
20:50:02 +0200:
> Add a wrapper to prevent drivers and core code from directly calling
> the ->select_chip hook which we are about to deprecate.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 23 +++--
> drivers/mtd/nand/raw/jz4740_nand.c | 4 +-
> drivers/mtd/nand/raw/nand_base.c | 114 ++++++++++++++-------
> drivers/mtd/nand/raw/r852.c | 4 +-
> include/linux/mtd/rawnand.h | 4 +
> 5 files changed, 98 insertions(+), 51 deletions(-)
>
So far I am glad to see all these changes.
About the ->select_chip() removal, I wonder if it would not be better
to also change the local variables "chipnr" or "chip_number" (or
even "i") that suggest that this ID selects a chip, while it
actually selects a die in a chip (and it is possible to have multiple
die on a chip, so multiple CS for one single NAND chip).
Do you think it is worth the change ? If yes, would it fit in this patch
or is it better to do this change elsewhere?
Thanks,
Miquèl
next prev parent reply other threads:[~2018-10-29 13:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 18:49 [PATCH 00/15] mtd: rawnand: 3rd batch of cleanup Boris Brezillon
2018-10-23 18:49 ` [PATCH 01/15] mtd: rawnand: Stop passing mtd_info objects to internal functions Boris Brezillon
2018-10-23 18:49 ` [PATCH 02/15] mtd: rawnand: Reorganize code to avoid forward declarations Boris Brezillon
2018-10-23 18:49 ` [PATCH 03/15] mtd: rawnand: legacy: Drop useless test in nand_legacy_set_defaults() Boris Brezillon
2018-10-23 18:50 ` [PATCH 04/15] mtd: rawnand: Move nand_exec_op() to internal.h Boris Brezillon
2018-10-23 18:50 ` [PATCH 05/15] mtd: rawnand: Remove unused NAND_CONTROLLER_ALLOC flag Boris Brezillon
2018-10-23 18:50 ` [PATCH 06/15] mtd: rawnand: Add nand_[de]select_target() helpers Boris Brezillon
2018-10-29 13:36 ` Miquel Raynal [this message]
2018-10-29 13:39 ` Miquel Raynal
2018-10-29 13:57 ` Boris Brezillon
2018-10-29 14:06 ` Miquel Raynal
2018-10-29 14:16 ` Boris Brezillon
2018-10-29 14:25 ` Miquel Raynal
2018-10-23 18:50 ` [PATCH 07/15] mtd: rawnand: Pass the CS line to be selected in struct nand_operation Boris Brezillon
2018-10-23 18:50 ` [PATCH 08/15] mtd: rawnand: Make ->select_chip() optional when ->exec_op() is implemented Boris Brezillon
2018-10-23 18:50 ` [PATCH 09/15] mtd: rawnand: fsmc: Stop implementing ->select_chip() Boris Brezillon
2018-10-23 18:50 ` [PATCH 10/15] mtd: rawnand: marvell: " Boris Brezillon
2018-10-23 18:50 ` [PATCH 11/15] mtd: rawnand: tegra: " Boris Brezillon
2018-10-23 18:50 ` [PATCH 12/15] mtd: rawnand: vf610: " Boris Brezillon
2018-10-23 18:50 ` [PATCH 13/15] mtd: rawnand: Deprecate the ->select_chip() hook Boris Brezillon
2018-10-23 18:50 ` [PATCH 14/15] mtd: rawnand: Move the ->exec_op() method to nand_controller_ops Boris Brezillon
2018-10-23 18:50 ` [PATCH 15/15] mtd: rawnand: Move ->setup_data_interface() " Boris Brezillon
2018-11-06 13:08 ` [PATCH 00/15] mtd: rawnand: 3rd batch of cleanup Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029143647.2efe60cb@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@nxp.com \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marc.w.gonzalez@free.fr \
--cc=marek.vasut@gmail.com \
--cc=maximlevitsky@gmail.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=tudor.ambarus@microchip.com \
--cc=xiaolei.li@mediatek.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox