Re: [PATCH] mtd: nand: Fix nanddev_neraseblocks()

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Sun, 28 Oct 2018
12:29:55 +0100:

> nanddev_neraseblocks() currently returns the number pages per LUN
> instead of the total number of eraseblocks.
> 
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND devices")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
>  include/linux/mtd/nand.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index abe975c87b90..78b86dea2f29 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -324,9 +324,8 @@ static inline unsigned int nanddev_ntargets(const struct nand_device *nand)
>   */
>  static inline unsigned int nanddev_neraseblocks(const struct nand_device *nand)
>  {
> -	return (u64)nand->memorg.luns_per_target *
> -	       nand->memorg.eraseblocks_per_lun *
> -	       nand->memorg.pages_per_eraseblock;
> +	return nand->memorg.ntargets * nand->memorg.luns_per_target *
> +	       nand->memorg.eraseblocks_per_lun;
>  }
>  
>  /**


Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl