From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk ([195.92.253.2]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gINSP-0006yb-DG for linux-mtd@lists.infradead.org; Fri, 02 Nov 2018 00:37:03 +0000 Date: Fri, 2 Nov 2018 00:34:34 +0000 From: Al Viro To: Daniel Walker Cc: Nikunj Kela , David Woodhouse , xe-linux-external@cisco.com, Rod Whitby , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make JFFS2 endianness configurable Message-ID: <20181102003434.GW32577@ZenIV.linux.org.uk> References: <20181101225603.17806-1-nkela@cisco.com> <20181102000236.rqho7txtb7gv543t@zorba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181102000236.rqho7txtb7gv543t@zorba> Sender: Al Viro List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Nov 01, 2018 at 05:02:36PM -0700, Daniel Walker wrote: > > > > On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by config options. > > > > It defaults to native-endian (the previously hard-coded option). > > > > Some architectures benefit from having a single known endianness > > of JFFS2 filesystem (for data, not executables) independent of the > > endianness of the processor (ARM processors can be switched to either > > endianness at run-time). > > > > > The description is pretty sad .. We have a product which we released that uses > JFFS2, and that product was release with a kernel in one endianness. Then later > on we decided to change the endianness and now we're stuck with a JFFS2 > partition that has the wrong endiannes, in a released product. This patch allows > us to set the endianness to something different from the architecture setting. > > So there a significant use case for the change, at least for Cisco. FWIW, can't we detect it at mount time, as e.g. UFS does?