From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
devel@driverdev.osuosl.org, Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH] staging: Remove the mt29f_spinand driver
Date: Mon, 5 Nov 2018 11:12:27 +0100 [thread overview]
Message-ID: <20181105111227.7bf08cfa@xps13> (raw)
In-Reply-To: <20181022201059.8630-1-boris.brezillon@bootlin.com>
Hi Greg,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Mon, 22 Oct 2018
22:10:59 +0200:
> A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and
> Micron's MT29F devices are now supported in
> drivers/mtd/nand/spi/micron.c.
>
> Remove the old driver.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Hello,
>
> If anything is missing in drivers/mtd/nand/spi/micron.c to properly
> support the devices supported by the mt29f_spinand driver, please let
> me know.
> I might accept to delay removal of this driver if I have some guarantees
> that existing users will actually switch to the new driver at some
> point.
>
> Regards,
>
> Boris
> ---
I plan to apply this patch but I would like your approval first.
As a summary, the mt29f_spinand driver is a Micron SPI NAND chip
driver interfacing with the raw NAND API (which is 'wrong').
Boris has recently contributed a SPI NAND framework supporting SPI
NAND chips from several vendors, including Micron, that is supposed to
take over this driver.
Do you see anything that should prevent us to remove it now?
> drivers/staging/Kconfig | 2 -
> drivers/staging/Makefile | 1 -
> drivers/staging/mt29f_spinand/Kconfig | 16 -
> drivers/staging/mt29f_spinand/Makefile | 1 -
> drivers/staging/mt29f_spinand/TODO | 13 -
> drivers/staging/mt29f_spinand/mt29f_spinand.c | 980 ------------------
> drivers/staging/mt29f_spinand/mt29f_spinand.h | 106 --
> 7 files changed, 1119 deletions(-)
> delete mode 100644 drivers/staging/mt29f_spinand/Kconfig
> delete mode 100644 drivers/staging/mt29f_spinand/Makefile
> delete mode 100644 drivers/staging/mt29f_spinand/TODO
> delete mode 100644 drivers/staging/mt29f_spinand/mt29f_spinand.c
> delete mode 100644 drivers/staging/mt29f_spinand/mt29f_spinand.h
>
Thanks,
Miquèl
next prev parent reply other threads:[~2018-11-05 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 20:10 [PATCH] staging: Remove the mt29f_spinand driver Boris Brezillon
2018-11-05 10:12 ` Miquel Raynal [this message]
2018-11-05 13:29 ` Greg Kroah-Hartman
2018-11-05 14:27 ` Miquel Raynal
2018-11-05 14:34 ` Greg Kroah-Hartman
2018-11-06 13:04 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105111227.7bf08cfa@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).