From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Daniel Danzberger <daniel@dd-wrt.com>
Cc: linux-mtd@lists.infradead.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] mtd: allow multiple -(name) parts on cmdline.
Date: Mon, 5 Nov 2018 15:39:37 +0100 [thread overview]
Message-ID: <20181105153937.041c4dd4@bbrezillon> (raw)
In-Reply-To: <20181105133752.27480-1-daniel@dd-wrt.com>
+Rafal for the subpartition stuff
Hi Daniel,
On Mon, 5 Nov 2018 14:37:52 +0100
Daniel Danzberger <daniel@dd-wrt.com> wrote:
> This allows to specify multiple -(name) SIZE_REMAINING partitions on the
> commandline parser.
>
> Example:
> mtdparts=physmap-flash.0:256k(uboot),128k(params),-(firmware),1966080(kernel),-(rootfs)
Now that Rafal introduced sub-partitioning support I'd prefer to go for
this solution. If I take your example, that would give something like:
mtdparts=physmap-flash.0:256k(uboot),128k(params),-(firmware);firmware:1966080(kernel),-(rootfs)
I'm not entirely sure, but I think all you'd have to do to support that
is add "cmdline" to the default_subpartition_type[] array [1] (or
simply use default_partition_type since default_subpartition_type and
default_partition_type would be the same after this change).
Regards,
Boris
[1]https://elixir.bootlin.com/linux/latest/source/drivers/mtd/mtdpart.c#L800
prev parent reply other threads:[~2018-11-05 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 13:37 [PATCH] mtd: allow multiple -(name) parts on cmdline Daniel Danzberger
2018-11-05 14:39 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105153937.041c4dd4@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=daniel@dd-wrt.com \
--cc=linux-mtd@lists.infradead.org \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox