From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>, Han Xu <han.xu@nxp.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Xiaolei Li <xiaolei.li@mediatek.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Stefan Agner <stefan@agner.ch>
Subject: Re: [PATCH 00/15] mtd: rawnand: 3rd batch of cleanup
Date: Tue, 6 Nov 2018 14:08:42 +0100 [thread overview]
Message-ID: <20181106140842.59cf24bc@xps13> (raw)
In-Reply-To: <20181023185011.3356-1-boris.brezillon@bootlin.com>
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Tue, 23 Oct 2018
20:49:56 +0200:
> Hello,
>
> After the sanitization of the raw NAND API, here is a smaller
> patchset continuing in this direction.
>
> Patch 1 is just a follow-up on the "stop passing mtd_info objects
> around" patches, except this times it takes care of internal functions.
> There's still a lot of sanitization to do in drivers in order to get
> rid of those mtd params, but I'll leave that to driver maintainers.
>
> Patch 2 is trying to get rid of 3 forward declarations that are not
> really needed.
>
> Patch 3 is getting rid of useless test in nand_legacy_set_defaults().
>
> Patch 4 is making nand_exec_op() private, so that NAND controller
> drivers are not tempted to use it.
>
> Patch 5 is getting rid of an unused flag that has been around for quite
> some time.
>
> Patches 6 to 13 are deprecating the ->select_chip() hook, which should
> now be replaced by internal target/die selection logic directly called
> from the ->exec_op() and ecc.read/write_xxx() implementations. The
> rational behind this change is that modern controller now take care of
> asserting/deasserting the CS pin on a per-operation basis, and if we
> ever want to implement advanced queuing logic (instead of the basic
> serialization we currently have) we'll have to attach a CS line to the
> operation we want to execute.
Would you mind rebasing this series on nand/next (small conflict
because of the recent introduction of gpio helpers in the NAND core)
and also add a patch to do the same thing as above on the ams-delta
driver (just converted to ->exec_op()).
For the ST, Meson, Arasan and PLxxx drivers, I'll ask the authors to
rebase and do the necessary changes on top of your work.
Thanks,
Miquèl
prev parent reply other threads:[~2018-11-06 13:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 18:49 [PATCH 00/15] mtd: rawnand: 3rd batch of cleanup Boris Brezillon
2018-10-23 18:49 ` [PATCH 01/15] mtd: rawnand: Stop passing mtd_info objects to internal functions Boris Brezillon
2018-10-23 18:49 ` [PATCH 02/15] mtd: rawnand: Reorganize code to avoid forward declarations Boris Brezillon
2018-10-23 18:49 ` [PATCH 03/15] mtd: rawnand: legacy: Drop useless test in nand_legacy_set_defaults() Boris Brezillon
2018-10-23 18:50 ` [PATCH 04/15] mtd: rawnand: Move nand_exec_op() to internal.h Boris Brezillon
2018-10-23 18:50 ` [PATCH 05/15] mtd: rawnand: Remove unused NAND_CONTROLLER_ALLOC flag Boris Brezillon
2018-10-23 18:50 ` [PATCH 06/15] mtd: rawnand: Add nand_[de]select_target() helpers Boris Brezillon
2018-10-29 13:36 ` Miquel Raynal
2018-10-29 13:39 ` Miquel Raynal
2018-10-29 13:57 ` Boris Brezillon
2018-10-29 14:06 ` Miquel Raynal
2018-10-29 14:16 ` Boris Brezillon
2018-10-29 14:25 ` Miquel Raynal
2018-10-23 18:50 ` [PATCH 07/15] mtd: rawnand: Pass the CS line to be selected in struct nand_operation Boris Brezillon
2018-10-23 18:50 ` [PATCH 08/15] mtd: rawnand: Make ->select_chip() optional when ->exec_op() is implemented Boris Brezillon
2018-10-23 18:50 ` [PATCH 09/15] mtd: rawnand: fsmc: Stop implementing ->select_chip() Boris Brezillon
2018-10-23 18:50 ` [PATCH 10/15] mtd: rawnand: marvell: " Boris Brezillon
2018-10-23 18:50 ` [PATCH 11/15] mtd: rawnand: tegra: " Boris Brezillon
2018-10-23 18:50 ` [PATCH 12/15] mtd: rawnand: vf610: " Boris Brezillon
2018-10-23 18:50 ` [PATCH 13/15] mtd: rawnand: Deprecate the ->select_chip() hook Boris Brezillon
2018-10-23 18:50 ` [PATCH 14/15] mtd: rawnand: Move the ->exec_op() method to nand_controller_ops Boris Brezillon
2018-10-23 18:50 ` [PATCH 15/15] mtd: rawnand: Move ->setup_data_interface() " Boris Brezillon
2018-11-06 13:08 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106140842.59cf24bc@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@nxp.com \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marc.w.gonzalez@free.fr \
--cc=marek.vasut@gmail.com \
--cc=maximlevitsky@gmail.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=tudor.ambarus@microchip.com \
--cc=xiaolei.li@mediatek.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox