From: Boris Brezillon <boris.brezillon@bootlin.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<marek.vasut@gmail.com>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <alexandre.belloni@bootlin.com>,
<cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH v3 1/2] mtd: spi-nor: Make sure SFDP-based 4B_OPCODE support detection works correctly
Date: Fri, 9 Nov 2018 11:15:48 +0100 [thread overview]
Message-ID: <20181109111548.6b9d2f3d@bbrezillon> (raw)
In-Reply-To: <6fa42403-3a20-cdbe-caa7-d90c88b51e27@microchip.com>
On Fri, 9 Nov 2018 09:57:13 +0000
<Tudor.Ambarus@microchip.com> wrote:
> >> When SNOR_F_4B_OPCODES comes from bfpt, addr_width is set to 4. For the id-based
> >> caps detection, when mtd->size > 0x1000000, we set nor->addr_width = 4 too.
> >>
> >> The only uncovered case would be when
> >> } else if (info->addr_width) {
> >> nor->addr_width = info->addr_width;
> >>
> >> but this can be solved by reordering the else if cases.
> >>
> >> if (nor->addr_width) {
> >> /* already configured from SFDP */
> >> } else if (mtd->size > 0x1000000) {
> >> ...
> >> } else if (info->addr_width) {
> >> nor->addr_width = info->addr_width;
> >> } else {
> >> nor->addr_width = 3;
> >> }
> >>
> >> What do you think?
> >
> > I'd rather not change that in this patch, but feel free to propose
> > a patch on top of mine to simplify the logic if you think it's
> > needed.
> >
>
> yeah, it can be made in a separate patch.
If you're okay with the current version, can you add a R-b?
Thanks,
Boris
next prev parent reply other threads:[~2018-11-09 10:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 14:45 [PATCH v3 1/2] mtd: spi-nor: Make sure SFDP-based 4B_OPCODE support detection works correctly Boris Brezillon
2018-10-31 14:45 ` [PATCH v3 2/2] mtd: spi-nor: Use 4B opcodes when the NOR advertises both 3B and 4B Boris Brezillon
2018-11-09 10:49 ` Tudor.Ambarus
2018-11-16 11:57 ` Tudor.Ambarus
2018-11-16 13:42 ` Alexandre Belloni
2018-11-20 13:18 ` Tudor.Ambarus
2018-11-20 15:01 ` Alexandre Belloni
2018-11-21 12:57 ` Boris Brezillon
2018-11-08 16:55 ` [PATCH v3 1/2] mtd: spi-nor: Make sure SFDP-based 4B_OPCODE support detection works correctly Tudor.Ambarus
2018-11-08 17:08 ` Boris Brezillon
2018-11-09 9:57 ` Tudor.Ambarus
2018-11-09 10:03 ` Boris Brezillon
2018-11-09 10:15 ` Boris Brezillon [this message]
2018-11-09 9:57 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109111548.6b9d2f3d@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).