From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTj1K-00081g-2P for linux-mtd@lists.infradead.org; Mon, 03 Dec 2018 07:52:01 +0000 From: Boris Brezillon To: Huijin Park , Boris Brezillon Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , linux-mtd@lists.infradead.org, bbanghj.park@gmail.com Subject: Re: [v3] mtd: spi-nor: cast to u64 to avoid uint overflows Date: Mon, 3 Dec 2018 08:51:54 +0100 Message-Id: <20181203075154.28637-1-boris.brezillon@bootlin.com> In-Reply-To: <1543392134-1443-1-git-send-email-huijin.park@samsung.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2018-11-28 at 08:02:14 UTC, Huijin Park wrote: > From: "huijin.park" > > The "params->size" is defined as "u64". > And "info->sector_size" and "info->n_sectors" are defined as > unsigned int and u16. > Thus, u64 data might have strange data(loss data) if the result > overflows an unsigned int. > This patch casts "info->sector_size" to an u64. > > Signed-off-by: huijin.park > Reviewed-by: Geert Uytterhoeven Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks. Boris