From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Mathieu Malaterre <malat@debian.org>
Cc: Paul Burton <paul.burton@mips.com>,
trivial@kernel.org, kernel-janitors@vger.kernel.org,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: annotate implicit fall throughs
Date: Mon, 3 Dec 2018 22:27:26 +0100 [thread overview]
Message-ID: <20181203222726.23e747ae@bbrezillon> (raw)
In-Reply-To: <20181203212214.8862-1-malat@debian.org>
Hi Mathieu,
The subject prefix should be "mtd: rawnand: jz4780:" not "mips:"
Regards,
Boris
On Mon, 3 Dec 2018 22:22:13 +0100
Mathieu Malaterre <malat@debian.org> wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 731c6051d91e..7201827809e9 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
> switch (size8) {
> case 3:
> dest8[2] = (val >> 16) & 0xff;
> + /* fall through */
> case 2:
> dest8[1] = (val >> 8) & 0xff;
> + /* fall through */
> case 1:
> dest8[0] = val & 0xff;
> break;
next prev parent reply other threads:[~2018-12-03 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 21:22 [PATCH] mips: annotate implicit fall throughs Mathieu Malaterre
2018-12-03 21:27 ` Boris Brezillon [this message]
2018-12-04 20:10 ` [PATCH v2] mtd: rawnand: jz4780: " Mathieu Malaterre
2018-12-07 18:51 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203222726.23e747ae@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=harveyhuntnexus@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=malat@debian.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul.burton@mips.com \
--cc=richard@nod.at \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).