linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Yong Qin <Yong.Qin@cypress.com>
Cc: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	"cyrille.pitchen@wedev4u.fr" <cyrille.pitchen@wedev4u.fr>,
	James Tomasetta <James.Tomasetta@cypress.com>,
	Jimmy Zhao <jimmy.zhao@nxp.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: SPI-NOR FS512S incorrect CR3NV[1] value
Date: Tue, 4 Dec 2018 10:03:30 +0100	[thread overview]
Message-ID: <20181204100330.28acbecd@bbrezillon> (raw)
In-Reply-To: <DM5PR06MB322865B43A86A57E77C92F748FAF0@DM5PR06MB3228.namprd06.prod.outlook.com>

Hi Yong,

On Tue, 4 Dec 2018 01:37:14 +0000
Yong Qin <Yong.Qin@cypress.com> wrote:

> Hi Boris,
> 
> Do you mean the SFDP table?

Sorry, I meant the SMPT (Sector Map Parameter Table) section of
the SFDP table. See page 130 of this datasheet [1].

> Can you please share me more detail of what is wrong, i.e., which
> parameter, what is expect value and what you get?

See "Table 70. Sector Map Parameter", CR3NV[1] is always set to one,
and when we retrieve this value at runtime we get a 0. Which means
we won't find a matching mapid when iterating over the map table, hence
the bug reported by Yogesh.

If CR3NV[1] is always 0, then the SMPT should be fixed accordingly:

CR3NV[3]  CR1NV[2]  CR3NV[1]  Index  Value Description
0         0         0         00h    4 kB sectors at bottom with remainder 256 kB sectors
0         1         0         02h    4 kB sectors at top with remainder 256 kB sectors
1         0         0         04h    Uniform 256 kB sectors

Regards,

Boris

[1]http://www.cypress.com/file/216376/download

  reply	other threads:[~2018-12-04  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  4:33 FW: SPI-NOR FS512S incorrect CR3NV[1] value Yogesh Narayan Gaur
2018-12-03  7:38 ` Boris Brezillon
2018-12-04  1:37   ` Yong Qin
2018-12-04  9:03     ` Boris Brezillon [this message]
2018-12-05 19:21       ` Yong Qin
2018-12-05 19:27         ` Boris Brezillon
2018-12-05 19:29           ` Boris Brezillon
2018-12-05 19:39             ` Yong Qin
2018-12-06 16:30           ` James Tomasetta
2018-12-07  4:37             ` Yogesh Narayan Gaur
2018-12-07 15:02               ` James Tomasetta
2018-12-07 15:17                 ` Boris Brezillon
2018-12-17  6:22                   ` Pankaj Bansal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204100330.28acbecd@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=James.Tomasetta@cypress.com \
    --cc=Yong.Qin@cypress.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=jimmy.zhao@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tudor.ambarus@microchip.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).