From: Boris Brezillon <boris.brezillon@bootlin.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <marek.vasut@gmail.com>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 3/6] mtd: spi-nor: Stop passing info to set_4byte()
Date: Tue, 4 Dec 2018 20:37:35 +0100 [thread overview]
Message-ID: <20181204203735.32903c07@bbrezillon> (raw)
In-Reply-To: <6e5ba477-fae5-10f3-9ffb-802a9f024ecd@microchip.com>
On Tue, 4 Dec 2018 19:35:15 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 11/29/2018 04:10 PM, Boris Brezillon wrote:
> > info can be extracted from nor->info, no need to pass it as an
> > argument.
>
> Nice! If you move the assignment nor->info = info; earlier in spi_nor_scan(),
> you'll be able to spare more functions to pass info as argument.
You mean like in patch 6? ;)
next prev parent reply other threads:[~2018-12-04 19:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:10 [PATCH v2 0/6] mtd: spi-nor: Random cleanups Boris Brezillon
2018-11-29 14:10 ` [PATCH v2 1/6] mtd: spi-nor: Drop inline on all internal helpers Boris Brezillon
2018-11-29 16:16 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2018-12-04 17:01 ` Tudor.Ambarus
2018-11-29 14:10 ` [PATCH v2 2/6] mtd: spi-nor: Avoid forward declaration of internal functions Boris Brezillon
2018-12-04 19:09 ` Tudor.Ambarus
2018-12-05 8:09 ` Boris Brezillon
2018-12-05 8:40 ` Tudor.Ambarus
2018-11-29 14:10 ` [PATCH v2 3/6] mtd: spi-nor: Stop passing info to set_4byte() Boris Brezillon
2018-11-29 16:23 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2018-12-04 19:35 ` Tudor.Ambarus
2018-12-04 19:37 ` Boris Brezillon [this message]
2018-11-29 14:10 ` [PATCH v2 4/6] mtd: spi-nor: Make the enable argument passed to set_byte() a bool Boris Brezillon
2018-12-04 19:38 ` Tudor.Ambarus
2018-11-29 14:10 ` [PATCH v2 5/6] mtd: spi-nor: Add an SPDX tag to spi-nor.c Boris Brezillon
2018-11-29 16:29 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2018-12-04 19:45 ` Tudor.Ambarus
2018-12-05 8:09 ` Boris Brezillon
2018-11-29 14:10 ` [PATCH v2 6/6] mtd: spi-nor: Move the nor->info assignment earlier in the scan func Boris Brezillon
2018-11-29 16:35 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2018-12-04 20:24 ` Tudor.Ambarus
2018-12-04 20:21 ` Tudor.Ambarus
2018-12-05 8:11 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204203735.32903c07@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).