From: Boris Brezillon <boris.brezillon@bootlin.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <marek.vasut@gmail.com>, <alexandre.belloni@bootlin.com>,
<richard@nod.at>, <linux-mtd@lists.infradead.org>,
<alexander.sverdlin@nokia.com>, <computersforpeace@gmail.com>,
<dwmw2@infradead.org>
Subject: Re: [PATCH v4 3/3] mtd: spi-nor: Add a post BFPT fixup for MX25L25635E
Date: Wed, 5 Dec 2018 17:50:46 +0100 [thread overview]
Message-ID: <20181205175046.1554cf61@bbrezillon> (raw)
In-Reply-To: <ff941bc1-8165-a188-1814-8eede77f3daf@microchip.com>
On Wed, 5 Dec 2018 16:41:05 +0000
<Tudor.Ambarus@microchip.com> wrote:
> On 11/29/2018 04:41 PM, Boris Brezillon wrote:
> > MX25L25635F and MX25L25635E share the same JEDEC-ID, but the F variant
> > supports 4-byte opcodes while the E variant doesn't. We need a way to
> > differentiate those 2 chips and set the SNOR_F_4B_OPCODES flag only for
> > the F variant.
> >
> > Luckily, 4-byte opcode support is not the only difference: Fast Read
> > 4-4-4 is only supported by the F variant, and this feature is
> > advertised in the BFPT table. Use this to decide when to set the
> > SNOR_F_4B_OPCODES flag.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
> Looks good. I'm not very keen of seeing yet another style when declaring spi nor
> ids, but I can live with it.
Oops. Will fix that in v2.
prev parent reply other threads:[~2018-12-05 16:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:41 [PATCH v4 0/3] mtd: spi-nor: mx25l25635f: Use 4B opcodes Boris Brezillon
2018-11-29 14:41 ` [PATCH v4 1/3] mtd: spi-nor: Add the SNOR_F_4B_OPCODES flag Boris Brezillon
2018-12-05 15:08 ` Tudor.Ambarus
2018-12-05 15:19 ` Boris Brezillon
2018-12-05 15:48 ` Tudor.Ambarus
2018-12-05 16:00 ` Boris Brezillon
2018-12-05 16:26 ` Tudor.Ambarus
2018-12-05 16:32 ` Boris Brezillon
2018-12-05 16:54 ` Boris Brezillon
2018-11-29 14:41 ` [PATCH v4 2/3] mtd: spi-nor: Add a post BFPT parsing fixup hook Boris Brezillon
2018-12-05 16:35 ` Tudor.Ambarus
2018-12-05 16:47 ` Boris Brezillon
2018-12-06 10:25 ` Boris Brezillon
2018-11-29 14:41 ` [PATCH v4 3/3] mtd: spi-nor: Add a post BFPT fixup for MX25L25635E Boris Brezillon
2018-12-05 16:41 ` Tudor.Ambarus
2018-12-05 16:50 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205175046.1554cf61@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexander.sverdlin@nokia.com \
--cc=alexandre.belloni@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).