From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hsiangkao@mail.ru,
kirill.shutemov@linux.intel.com, stable@vger.kernel.org,
zhangjun <openzhangj@gmail.com>
Subject: Re: [PATCH] ubifs: Get/put page when changing PG_private
Date: Mon, 17 Dec 2018 13:59:44 +0300 [thread overview]
Message-ID: <20181217105944.a7eylrxi5pni4mqq@kshutemo-mobl1> (raw)
In-Reply-To: <20181215150130.19381-1-richard@nod.at>
On Sat, Dec 15, 2018 at 04:01:30PM +0100, Richard Weinberger wrote:
> The page migration code assumes that a page with PG_private
> set has its page count elevated by 1.
> UBIFS never did this and therefore the migration code was unable
> to migrate some pages owned by UBIFS.
> The lead to situations where the CMA memory allocator failed to
> allocate memory.
>
> Fix this by using get/put_page when changing PG_private.
Looks good to me.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: <stable@vger.kernel.org>
> Cc: zhangjun <openzhangj@gmail.com>
> Fixes: 4ac1c17b2044 ("UBIFS: Implement ->migratepage()")
It is fair to reference the commit here. But I believe the bug itself
predates the commit and relevant not only for migration.
We might make it clear in the commit message.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-12-17 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 15:01 [PATCH] ubifs: Get/put page when changing PG_private Richard Weinberger
2018-12-15 20:38 ` zhangjun
2018-12-17 10:59 ` Kirill A. Shutemov [this message]
2018-12-17 11:32 ` Richard Weinberger
2018-12-21 8:56 ` Richard Weinberger
2018-12-21 10:35 ` Kirill A. Shutemov
2018-12-25 2:42 ` zhangjun
2018-12-25 21:08 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217105944.a7eylrxi5pni4mqq@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=hsiangkao@mail.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=openzhangj@gmail.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox