From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org ([198.145.29.99])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1gZxzf-000804-TK
 for linux-mtd@lists.infradead.org; Thu, 20 Dec 2018 13:04:09 +0000
Date: Thu, 20 Dec 2018 14:03:48 +0100
From: Boris Brezillon <bbrezillon@kernel.org>
To: Emil Lenngren <emil.lenngren@gmail.com>
Cc: linux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: spinand: Fix Macronix ECC Status Read
Message-ID: <20181220140341.16e7c518@bbrezillon>
In-Reply-To: <20181220124658.11565-1-emil.lenngren@gmail.com>
References: <20181220124658.11565-1-emil.lenngren@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

+Miquel

Hi Emil,

Can you please Cc the NAND and MTD maintainers next time?

On Thu, 20 Dec 2018 13:46:58 +0100
Emil Lenngren <emil.lenngren@gmail.com> wrote:

> The datasheet specifies the upper four bits are reserved.
> Testing on real hardware shows that these bits can indeed be nonzero.
> 
> Signed-off-by: Emil Lenngren <emil.lenngren@gmail.com>

Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>

> ---
>  drivers/mtd/nand/spi/macronix.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
> index 98f6b9c4b6..d16b57081c 100644
> --- a/drivers/mtd/nand/spi/macronix.c
> +++ b/drivers/mtd/nand/spi/macronix.c
> @@ -10,6 +10,7 @@
>  #include <linux/mtd/spinand.h>
>  
>  #define SPINAND_MFR_MACRONIX		0xC2
> +#define MACRONIX_ECCSR_MASK		0x0F
>  
>  static SPINAND_OP_VARIANTS(read_cache_variants,
>  		SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
> @@ -55,7 +56,12 @@ static int mx35lf1ge4ab_get_eccsr(struct spinand_device *spinand, u8 *eccsr)
>  					  SPI_MEM_OP_DUMMY(1, 1),
>  					  SPI_MEM_OP_DATA_IN(1, eccsr, 1));
>  
> -	return spi_mem_exec_op(spinand->spimem, &op);
> +	int ret = spi_mem_exec_op(spinand->spimem, &op);
> +	if (ret)
> +		return ret;
> +
> +	*eccsr &= MACRONIX_ECCSR_MASK;
> +	return 0;
>  }
>  
>  static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,