From: Boris Brezillon <bbrezillon@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: Kenneth Johansson <ken@kenjo.org>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v2] mtd: rawnand: nandsim: Add support to disable subpage writes.
Date: Fri, 4 Jan 2019 10:01:17 +0100 [thread overview]
Message-ID: <20190104100117.394876ec@bbrezillon> (raw)
In-Reply-To: <20190104095302.236a19dc@bbrezillon>
+Miquel
Kenneth, please Cc the NAND maintainers next time.
On Fri, 4 Jan 2019 09:53:02 +0100
Boris Brezillon <bbrezillon@kernel.org> wrote:
> Hi Richard,
>
> On Thu, 03 Jan 2019 21:43:13 +0100
> Richard Weinberger <richard@nod.at> wrote:
>
> > > It's true that you could change the vid offset with ubiattach but that
> > > require you know that the LEB missmatch error you get is fixed by a
> > > different vid offset and you need to understand what that value should be.
> > > This way you only need to match the basic mtd parameters and the rest
> > > will just work automatically.
> >
> > I agree that adding a parameter to nandsim to control subpage behavior
> > is nice.
> > But please keep in mind that nandsim will never perfectly match your hardware.
> >
> > Boris, unless you have objections I'm fine to control NAND_NO_SUBPAGE_WRITE
> > in nandsim using a module parameter.
>
> Hm, I'd really like to have nandsim replaced by something more generic
> at some point (mtdsim or MTD/NAND emulation in qemu using a virtio
> iface), so adding new features/option to this driver is something I'd
> like to avoid. This being said, this new MTD/NAND emulation
> infrastructure is not there yet, and I don't think I'll have time to
> work on it (I started working on mtdsim a while back, and someone took
> over this work, but it stopped at some point).
>
> To sum-up, if you think this is absolutely necessary (given the
> discussion I'm not convinced it is) I'm okay to add this module param,
> but I'd prefer if people were working on a solution to replace all
> those emulation layers we have right now (mtdram, nandsim, ...).
>
> Regards,
>
> Boris
next prev parent reply other threads:[~2019-01-04 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 12:40 [PATCH v2] mtd: rawnand: nandsim: Add support to disable subpage writes Kenneth Johansson
2018-12-22 12:53 ` Kenneth Johansson
2019-01-03 20:43 ` Richard Weinberger
2019-01-04 8:53 ` Boris Brezillon
2019-01-04 9:01 ` Boris Brezillon [this message]
2020-09-23 14:58 ` Marc Kleine-Budde
2020-09-24 6:31 ` Richard Weinberger
2020-09-24 7:40 ` Marc Kleine-Budde
2020-09-24 10:28 ` Richard Weinberger
2020-09-24 10:56 ` Marc Kleine-Budde
2019-01-07 6:38 ` Kenneth Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104100117.394876ec@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=ken@kenjo.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).