From: bbrezillon@kernel.org (Boris Brezillon)
To: linux-mtd@lists.infradead.org
Subject: mtd: cfi: cmdset_0001: Use struct_size() in kmalloc()
Date: Wed, 16 Jan 2019 09:40:40 +0100 [thread overview]
Message-ID: <20190116084040.29707-1-bbrezillon@kernel.org> (raw)
In-Reply-To: <20190108155244.GA15339@embeddedor>
From: Boris Brezillon <boris.brezillon@bootlin.com>
On Tue, 2019-01-08 at 15:52:44 UTC, "Gustavo A. R. Silva" wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> void *entry[];
> };
>
> instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
>
> instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL);
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Boris
prev parent reply other threads:[~2019-01-16 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 15:52 [PATCH] mtd: cfi: cmdset_0001: Use struct_size() in kmalloc() Gustavo A. R. Silva
2019-01-16 8:40 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116084040.29707-1-bbrezillon@kernel.org \
--to=bbrezillon@kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).