linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-mtd@lists.infradead.org,
	Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [PATCH] mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem'
Date: Fri, 18 Jan 2019 09:54:21 +0100	[thread overview]
Message-ID: <20190118095421.73387ccc@xps13> (raw)
In-Reply-To: <20190117173907.62198-1-luc.vanoostenryck@gmail.com>

Hi Luc,

Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote on Thu, 17 Jan
2019 18:39:07 +0100:

> The function jz_nand_ioremap_resource() needs a pointer to an __iomem
> pointer as its last argument but this argument is declared as:
> 	void * __iomem *base
> 
> Fix this by using the correct declaration:
> 	void __iomem **base
> which then also removes the following Sparse's warnings:
>   282:15: warning: incorrect type in assignment (different address spaces)
>   282:15:    expected void *[noderef] <asn:2>
>   282:15:    got void [noderef] <asn:2> *
>   322:57: warning: incorrect type in argument 4 (different address spaces)
>   322:57:    expected void *[noderef] <asn:2> *base
>   322:57:    got void [noderef] <asn:2> **
>   402:67: warning: incorrect type in argument 4 (different address spaces)
>   402:67:    expected void *[noderef] <asn:2> *base
>   402:67:    got void [noderef] <asn:2> **
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Boris, do you want to take it in your fixes branch?


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

       reply	other threads:[~2019-01-18  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190117173907.62198-1-luc.vanoostenryck@gmail.com>
2019-01-18  8:54 ` Miquel Raynal [this message]
2019-01-18 11:43 ` mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem' Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118095421.73387ccc@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).