From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E55FC282DB for ; Mon, 21 Jan 2019 10:13:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28EF220870 for ; Mon, 21 Jan 2019 10:13:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PtaJIdXV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oCodAO4Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28EF220870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P6G8Va5M5WKc0KBSusiYnwJpvPRtasle4BNE9xEuVtA=; b=PtaJIdXVftCx9f ixwivqMI803bxAXkm+M2EukjZ2GwzhrBE/lWzcIA6gXFgResyU4GqAT5lDgjQjIy/w7qYMCBq2vZs K92xf3AFVUptV9yMnhdwAPEHWmw/D2MVJFewTJ2n6rbARavwBzJu0o8bG7OFUx2eCp/ZpEogFYqEA fWsOfEmmdPJZtfXv+oeV+AjmjK18DNRKYiybmDEipo2fLEXwd0I6ITajg92gqO6WgPmF67Ms4xuwZ 9USEGLVqGOvKYxbcr3kKCaZzvmTJqQnZOGWv4AqoMUcP5B6391aCKdqnUJgsH2He3NpE1k2AnUrhV tCSjpMbOCCuU63Og5eog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glWZo-0002E3-3L; Mon, 21 Jan 2019 10:13:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glWZl-0002Dj-35 for linux-mtd@lists.infradead.org; Mon, 21 Jan 2019 10:13:06 +0000 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71E8A2085A; Mon, 21 Jan 2019 10:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548065584; bh=AuLUUOMWMr+c1eEPYC5iohHex+BZlqwSslb5gVTNPeU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oCodAO4QBuUQxB3OZXXuls/ImevhmF3zswsVFmIV6TLqiw59BIS1T8PbttOUNLHVf yKiYWMuMtVtxa7nXuP/pG5Kbfnw0g4/X4KStCGcaRELSwHL5aBx81+rCDtAq7GLaqA cpekGtXSGDDzJ9I0lWQFQzUlbSDQGA89CcSepwEQ= Date: Mon, 21 Jan 2019 11:12:55 +0100 From: Boris Brezillon To: "Bean Huo (beanhuo)" Subject: Re: [EXT] Re: [RESEND PATCH V2 2/2] mtd: core: NAND filling block Message-ID: <20190121111255.79be03de@bbrezillon> In-Reply-To: References: <20190119000135.0064da24@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190121_021305_149801_958652F1 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "richard@nod.at" , "boris.brezillon@bootlin.com" , "Zoltan Szubbocsev \(zszubbocsev\)" , "linux-mtd@lists.infradead.org" , "miquel.raynal@bootlin.com" , "tglx@linutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 21 Jan 2019 10:04:15 +0000 "Bean Huo (beanhuo)" wrote: > Hi, Boris > > >On Fri, 18 Jan 2019 22:12:04 +0000 > >"Bean Huo (beanhuo)" wrote: > > > >> + /* Corrupt page0 and page1, in order to simulate an > >> + * uncompleted eraseing scenario. Just for case of > >> + * power loss hits while below programming. in this > >> + * way, the PEB will be re-erased again. > >> + */ > >> + empty_page_mask |= 0x3; > >> + memset(data_buf, 0xAA, mtd->writesize); > > > >Why do you use the 0xaa pattern BTW? > > Random pattern or any pattern is ok. Just to fill in page. Let's use 0x0 then. This way all cells are actually in a "programmed" state. BTW, I'd still be interested in knowing more about the root cause of this issue. What causes this wrong "cell is erased" detection in your chips? I thought the ERASE operation was an iterative process and cells were being tested after each step to know whether they are erased or not in order to decide to do another step or stop. Am I wrong? What happens here to cause this erroneous detection? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/